Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367Ab3HTPBH (ORCPT ); Tue, 20 Aug 2013 11:01:07 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:40840 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111Ab3HTPBF convert rfc822-to-8bit (ORCPT ); Tue, 20 Aug 2013 11:01:05 -0400 Subject: Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <1377010458.26268.30.camel@iivanov-dev.int.mm-sol.com> Date: Tue, 20 Aug 2013 10:01:10 -0500 Cc: balbi@ti.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, rob@landley.net, gregkh@linuxfoundation.org, grant.likely@linaro.org, idos@codeaurora.org, mgautam@codeaurora.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, Paul Zimmerman Content-Transfer-Encoding: 8BIT Message-Id: <8691FDFE-326E-4198-838A-202D9EC988E1@codeaurora.org> References: <1376992565-22292-1-git-send-email-iivanov@mm-sol.com> <1376992565-22292-3-git-send-email-iivanov@mm-sol.com> <20130820122907.GU26587@radagast> <1377005543.26268.22.camel@iivanov-dev.int.mm-sol.com> <20130820133712.GC26587@radagast> <1377007751.26268.27.camel@iivanov-dev.int.mm-sol.com> <20130820143319.GG26587@radagast> <1377010458.26268.30.camel@iivanov-dev.int.mm-sol.com> To: "Ivan T. Ivanov" X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2498 Lines: 66 On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: >>> Hi, >>> >>> On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: >>>> Hi, >>>> >>>> On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: >>>>>> On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: >>>>>>> From: "Ivan T. Ivanov" >>>>>>> >>>>>>> These drivers handles control and configuration of the HS >>>>>>> and SS USB PHY transceivers. They are part of the driver >>>>>>> which manage Synopsys DesignWare USB3 controller stack >>>>>>> inside Qualcomm SoC's. >>>>>>> >>>>>>> Signed-off-by: Ivan T. Ivanov >>>>>>> --- >>>>>>> drivers/usb/phy/Kconfig | 11 ++ >>>>>>> drivers/usb/phy/Makefile | 2 + >>>>>>> drivers/usb/phy/phy-msm-dwc3-hs.c | 327 ++++++++++++++++++++++++++++++++ >>>>>>> drivers/usb/phy/phy-msm-dwc3-ss.c | 374 +++++++++++++++++++++++++++++++++++++ >>>>>> >>>>>> please rename these PHY drivers, they have nothing to do with DWC3. PHYs >>>>>> don't care about the USB controller. >>>>> >>>>> I think they are SNPS DesignWare PHY's, additionally >>>>> wrapped with Qualcomm logic. I could substitute "dwc3" >>>>> with just "dw", which will be more correct. >>>> >>>> alright, thank you. Let's add Paul to the loop since he might have very >>>> good insight in the synopsys PHYs. >>>> >>>> mental note: if any other platform shows up with Synopsys PHY, ask them >>>> to use this driver instead :-) >>> >>> I really doubt that this will bi possible. Control of the PHY's is >>> not directly trough ULPI, UTMI or PIPE3 interfaces, but trough >>> QSCRATCH registers, which of course is highly Qualcomm specific. >> >> isn't it a memory mapped IP ? doesn't synopsys provide their own set of >> registers ? > > From what I see it is not directly mapped. How QSCRATCH write and > reads transactions are translated to DW IP is unclear to me. I think the question is how does SW access them? - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/