Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548Ab3HTVqX (ORCPT ); Tue, 20 Aug 2013 17:46:23 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:58809 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246Ab3HTVqV (ORCPT ); Tue, 20 Aug 2013 17:46:21 -0400 Message-ID: <1377035588.32763.7.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 0/9] target: Add support for COMPARE_AND_WRITE (VAAI) emulation From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: "Nicholas A. Bellinger" , target-devel , lkml , linux-scsi , Hannes Reinecke , Martin Petersen , Chris Mason , James Bottomley Date: Tue, 20 Aug 2013 14:53:08 -0700 In-Reply-To: <20130820212912.GA9483@lst.de> References: <1377029280-19144-1-git-send-email-nab@daterainc.com> <20130820212912.GA9483@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 31 On Tue, 2013-08-20 at 23:29 +0200, Christoph Hellwig wrote: > On Tue, Aug 20, 2013 at 08:07:51PM +0000, Nicholas A. Bellinger wrote: > > > > It's also currently lacking the necessary sychronization between I/O > > submission of COMPARE_AND_WRITE verify instance and write instance > > user data, which is still being worked on in order to avoid additional > > overhead in the main I/O fast path. > > I don't think merging such a non-conforming implementation makes any sense. > Yes, I don't intend to merge anything that's not fully functional. The idea was to get review going on these pieces first. I'll be posting an PATCH-v2 to complete the implementation over the next days. > Also for a complex command like this with all it's race potential I would > really like to see some test cases to go along with it. > Yes, Eric @ PureStorage has a sg_compare_write that I'm using to test this. It's probably about time that this be included in upstream sg3-utils too.. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/