Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485Ab3HTWD3 (ORCPT ); Tue, 20 Aug 2013 18:03:29 -0400 Received: from g1t0028.austin.hp.com ([15.216.28.35]:8280 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117Ab3HTWD2 (ORCPT ); Tue, 20 Aug 2013 18:03:28 -0400 Message-ID: <1377036123.10300.475.camel@misato.fc.hp.com> Subject: Re: [PATCH] ACPI / PM: Hold acpi_scan_lock over system PM transitions From: Toshi Kani To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , Linux PCI , Linux PM list , Bjorn Helgaas , Mika Westerberg Date: Tue, 20 Aug 2013 16:02:03 -0600 In-Reply-To: <2852781.TfChGuuEkJ@vostro.rjw.lan> References: <2852781.TfChGuuEkJ@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 28 On Tue, 2013-08-20 at 01:47 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Bad things happen if ACPI hotplug events are handled during system > PM transitions, especially if devices are removed as a result. > To prevent those bad things from happening, acquire acpi_scan_lock > when a transition is started and release it when that transition > is complete or has been aborted. > > This fixes resume lockup on my test-bed Acer Aspire S5 that happens > when Thunderbolt devices are disconnected from the machine while > suspended. > > Signed-off-by: Rafael J. Wysocki The change looks good to me. Acked-by: Toshi Kani Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/