Date: Tue, 20 Aug 2013 15:07:39 -0700 (PDT)
Message-Id: <20130820.150739.295329075883411467.davem@davemloft.net>
To: al@alarsen.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: ethtool cannot change parameters when link is
 down
From: David Miller <davem@davemloft.net>
In-Reply-To: <1376819680-15359-1-git-send-email-al@alarsen.net>
References: <1376819680-15359-1-git-send-email-al@alarsen.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 24

From: Anders Larsen <al@alarsen.net>
Date: Sun, 18 Aug 2013 11:54:40 +0200

> When attempting to change e.g. the advertising mask when the link is down
> ecmd->speed is -1 causing mii_ethtool_sset() to bail out.
> 
> This bug bit when connecting to a gigabit switch through a 4-pin (industrial)
> cable, since link negotiation would not complete (both endpoints claimed to
> be gigabit-capable, but this is not possible with only 4 pins).
> Any attempt to fix this by setting autonegation to not offer 1000Mbps
> failed as the setting would not be accepted while the link was still down...
> 
> Set ecmd->speed to SPEED_1000 to satisfy mii_ethtool_sset()
> (the actual value of ecmd->speed doesn't matter as long as it is valid,
> since a re-negotation is forced afterwards).
> 
> Signed-off-by: Anders Larsen <al@alarsen.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/