Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013Ab3HUCFr (ORCPT ); Tue, 20 Aug 2013 22:05:47 -0400 Received: from intranet.asianux.com ([58.214.24.6]:52455 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab3HUCFq (ORCPT ); Tue, 20 Aug 2013 22:05:46 -0400 X-Spam-Score: -101.0 Message-ID: <5214201C.6080008@asianux.com> Date: Wed, 21 Aug 2013 10:04:12 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: jg1.han@samsung.com, khali@linux-fr.org, David.Woodhouse@intel.com, Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel/params.c: use scnprintf() instead of sprintf() References: <5212DFB0.8070902@asianux.com> <87siy4gan1.fsf@rustcorp.com.au> In-Reply-To: <87siy4gan1.fsf@rustcorp.com.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2004 Lines: 66 On 08/20/2013 02:05 PM, Rusty Russell wrote: > Chen Gang writes: > >> For some strings (e.g. version string), they are permitted to be larger >> than PAGE_SIZE (although meaningless), so recommend to use scnprintf() >> instead of sprintf(). > > Applied. > Thanks. > Thanks, > Rusty. > >> >> Signed-off-by: Chen Gang >> --- >> kernel/params.c | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/kernel/params.c b/kernel/params.c >> index 1f228a3..4da300f 100644 >> --- a/kernel/params.c >> +++ b/kernel/params.c >> @@ -241,7 +241,8 @@ int parse_args(const char *doing, >> } \ >> int param_get_##name(char *buffer, const struct kernel_param *kp) \ >> { \ >> - return sprintf(buffer, format, *((type *)kp->arg)); \ >> + return scnprintf(buffer, PAGE_SIZE, format, \ >> + *((type *)kp->arg)); \ >> } \ >> struct kernel_param_ops param_ops_##name = { \ >> .set = param_set_##name, \ >> @@ -285,7 +286,7 @@ EXPORT_SYMBOL(param_set_charp); >> >> int param_get_charp(char *buffer, const struct kernel_param *kp) >> { >> - return sprintf(buffer, "%s", *((char **)kp->arg)); >> + return scnprintf(buffer, PAGE_SIZE, "%s", *((char **)kp->arg)); >> } >> EXPORT_SYMBOL(param_get_charp); >> >> @@ -827,7 +828,7 @@ ssize_t __modver_version_show(struct module_attribute *mattr, >> struct module_version_attribute *vattr = >> container_of(mattr, struct module_version_attribute, mattr); >> >> - return sprintf(buf, "%s\n", vattr->version); >> + return scnprintf(buf, PAGE_SIZE, "%s\n", vattr->version); >> } >> >> extern const struct module_version_attribute *__start___modver[]; >> -- >> 1.7.7.6 > > -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/