Date: Wed, 21 Aug 2013 11:08:29 +0900
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Mike Galbraith <efault@gmx.de>, Paul Turner <pjt@google.com>,
        Alex Shi <alex.shi@intel.com>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Namhyung Kim <namhyung@kernel.org>, Lei Wen <leiwen@marvell.com>,
        Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH 04/10] sched, fair: Shrink sg_lb_stats and play memset
 games
Message-ID: <20130821020829.GA6142@lge.com>
References: <20130819160058.539049611@infradead.org>
 <20130819160425.310264395@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130819160425.310264395@infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2092
Lines: 49

On Mon, Aug 19, 2013 at 06:01:02PM +0200, Peter Zijlstra wrote:
> +static inline void init_sd_lb_stats(struct sd_lb_stats *sds)
> +{
> +	/*
> +	 * struct sd_lb_stats {
> +	 *	   struct sched_group *       busiest;             //     0  8
> +	 *	   struct sched_group *       this;                //     8  8
> +	 *	   long unsigned int          total_load;          //    16  8
> +	 *	   long unsigned int          total_pwr;           //    24  8
> +	 *	   long unsigned int          avg_load;            //    32  8
> +	 *	   struct sg_lb_stats {
> +	 *		   long unsigned int  avg_load;            //    40  8
> +	 *		   long unsigned int  group_load;          //    48  8
> +	 *	           ...
> +	 *	   } busiest_stat;                                 //    40 56
> +	 *	   struct sg_lb_stats	      this_stat;	   //    96 56
> +	 *
> +	 *	   // size: 152, cachelines: 3, members: 7
> +	 *	   // last cacheline: 24 bytes
> +	 * };
> +	 *
> +	 * Skimp on the clearing to avoid duplicate work. We can avoid clearing
> +	 * this_stat because update_sg_lb_stats() does a full clear/assignment.
> +	 * We must however clear busiest_stat::avg_load because
> +	 * update_sd_pick_busiest() reads this before assignment.
> +	 */
> +	memset(sds, 0, offsetof(struct sd_lb_stats, busiest_stat.group_load));

Hello, Peter.

IMHO, this is so tricky.
With below change, we can simply do 'offsetof(struct sd_lb_stats, busiest_stat)'.

@@ -4546,7 +4546,7 @@ static bool update_sd_pick_busiest(struct lb_env *env,
                                   struct sched_group *sg,
                                   struct sg_lb_stats *sgs)
 {
-       if (sgs->avg_load <= sds->busiest_stat.avg_load)
+       if (!sds->busiest && sgs->avg_load <= sds->busiest_stat.avg_load)
                return false;
 
        if (sgs->sum_nr_running > sgs->group_capacity)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/