Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462Ab3HUIDU (ORCPT ); Wed, 21 Aug 2013 04:03:20 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:22144 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933Ab3HUIDP (ORCPT ); Wed, 21 Aug 2013 04:03:15 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19vHbg/YaglhmpP36gbVlGW Date: Wed, 21 Aug 2013 01:03:13 -0700 From: Tony Lindgren To: Chen Baozi Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD Message-ID: <20130821080313.GC7656@atomide.com> References: <1375884321-30489-1-git-send-email-baozich@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1375884321-30489-1-git-send-email-baozich@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 39 * Chen Baozi [130807 07:18]: > The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET > rather than INCREMENTER_NUMERATOR_OFFSET. > > This is more likely a typo, since INCREMENTER_DENUMERATOR_RELOAD[23:17] is > reserved. It seems that it won't make much trouble without this fix, because > the useful [11:0] bits are mask and set the right value. Anyway, reading > from a right address is better choice. Thanks applying to omap-for-v3.12/fixes-non-critical. Tony > Signed-off-by: Chen Baozi > --- > arch/arm/mach-omap2/timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 1e77f11..ccc5c72 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void) > reg |= num; > __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET); > > - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) & > + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) & > NUMERATOR_DENUMERATOR_MASK; > reg |= den; > __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET); > -- > 1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/