Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751566Ab3HUIIl (ORCPT ); Wed, 21 Aug 2013 04:08:41 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:52348 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531Ab3HUIIh (ORCPT ); Wed, 21 Aug 2013 04:08:37 -0400 MIME-Version: 1.0 In-Reply-To: <1370521041-32318-29-git-send-email-lee.jones@linaro.org> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-29-git-send-email-lee.jones@linaro.org> Date: Wed, 21 Aug 2013 10:08:36 +0200 Message-ID: Subject: Re: [PATCH 28/33] ARM: ux500: Remove AUXDATA relating to MSP (Audio) clock-name bindings From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 31 On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote: > @@ -232,15 +232,6 @@ static struct of_dev_auxdata u8500_auxdata_lookup[] __initdata = { > /* Requires device name bindings. */ > OF_DEV_AUXDATA("stericsson,db8500-pinctrl", U8500_PRCMU_BASE, > "pinctrl-db8500", NULL), > - /* Requires clock name and DMA bindings. */ The comment is just wrong. > - OF_DEV_AUXDATA("stericsson,ux500-msp-i2s", 0x80123000, > - "ux500-msp-i2s.0", &msp0_platform_data), Look, it also adds &msp0_platform_data, which is vital. Result after boot: ALSA device list: No soundcards found. Before the patch set we had audio and I kind of liked it :-) I think you're able to set the device name as NULL though so we only add this platform data, try it out. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/