Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539Ab3HUISC (ORCPT ); Wed, 21 Aug 2013 04:18:02 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:38382 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429Ab3HUISA (ORCPT ); Wed, 21 Aug 2013 04:18:00 -0400 MIME-Version: 1.0 In-Reply-To: <1370521041-32318-22-git-send-email-lee.jones@linaro.org> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-22-git-send-email-lee.jones@linaro.org> Date: Wed, 21 Aug 2013 10:17:59 +0200 Message-ID: Subject: Re: [PATCH 21/33] clk: ux500: Add Device Tree support for the PRCC Kernel clock From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Mike Turquette , Ulf Hansson Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1957 Lines: 52 On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote: > This patch enables clocks to be specified from Device Tree via phandles > to the "prcc-kernel-clock" node. > > Cc: Mike Turquette > Cc: Ulf Hansson > Signed-off-by: Lee Jones (...) > static struct clk *prcmu_clk[PRCMU_NUM_CLKS]; > static struct clk *prcc_pclk[(PRCC_NUM_PERIPH_CLUSTERS + 1) * PRCC_PERIPHS_PER_CLUSTER]; > +static struct clk *prcc_kclk[(PRCC_NUM_PERIPH_CLUSTERS + 1) * PRCC_PERIPHS_PER_CLUSTER]; > > #define PRCC_SHOW(clk, base, bit) \ > clk[(base * PRCC_PERIPHS_PER_CLUSTER) + bit] > @@ -540,110 +541,136 @@ void u8500_clk_init(u32 clkrst1_base, u32 clkrst2_base, u32 clkrst3_base, > clk = clk_reg_prcc_kclk("p1_uart0_kclk", "uartclk", > clkrst1_base, BIT(0), CLK_SET_RATE_GATE); > clk_register_clkdev(clk, NULL, "uart0"); > + PRCC_KCLK_STORE(clk, 1, 0); > > clk = clk_reg_prcc_kclk("p1_uart1_kclk", "uartclk", > clkrst1_base, BIT(1), CLK_SET_RATE_GATE); > clk_register_clkdev(clk, NULL, "uart1"); > + PRCC_KCLK_STORE(clk, 1, 1); (etc) On device tree boots, clk_register_clkdev() is obviously pointless, as you're later deleting the AUXDATA connecting that device name to the clock. This should not be called at all on the DT boot path. However this looks cluttered as well: if (dt_probe) clk_register_clkdev(clk, NULL, "uart0"); else PRCC_KCLK_STORE(clk, 1, 0); Isn't it possible to fork a function u8500_clk_init_dt() to add all the clocks in the DT probe path and keep this function u8500_clk_init() as it is? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/