Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978Ab3HUKKu (ORCPT ); Wed, 21 Aug 2013 06:10:50 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:47306 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484Ab3HUKKs (ORCPT ); Wed, 21 Aug 2013 06:10:48 -0400 Date: Wed, 21 Aug 2013 11:10:43 +0100 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Mike Turquette , Ulf Hansson Subject: Re: [PATCH 19/33] clk: ux500: Add Device Tree support for the PRCMU clock Message-ID: <20130821101043.GI29850@lee--X1> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-20-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 29 On Wed, 21 Aug 2013, Linus Walleij wrote: > On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote: > > > This patch enables clocks to be specified from Device Tree via phandles > > to the "prcmu-clock" node. > (..) > > @@ -52,14 +54,17 @@ void u8500_clk_init(u32 clkrst1_base, u32 clkrst2_base, u32 clkrst3_base, > > clk = clk_reg_prcmu_gate("soc0_pll", NULL, PRCMU_PLLSOC0, > > CLK_IS_ROOT|CLK_IGNORE_UNUSED); > > clk_register_clkdev(clk, "soc0_pll", NULL); > > + prcmu_clk[PRCMU_PLLSOC0] = clk; > > Same comment on all these. > > No clk_register_clkdev() on the DT boot path please. I'll fix this during my ATAG removal patch-set. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/