Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374Ab3HUQYt (ORCPT ); Wed, 21 Aug 2013 12:24:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52269 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541Ab3HUQYs (ORCPT ); Wed, 21 Aug 2013 12:24:48 -0400 Date: Wed, 21 Aug 2013 09:24:47 -0700 From: Greg KH To: Daniel Gimpelevich Cc: j.dumon@option.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] hso: Fix stack corruption on some architectures Message-ID: <20130821162447.GC14364@kroah.com> References: <1377074599.4530.9.camel@chimera> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377074599.4530.9.camel@chimera> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 17 On Wed, Aug 21, 2013 at 01:43:19AM -0700, Daniel Gimpelevich wrote: > As Sergei Shtylyov explained in the #mipslinux IRC channel: > [Mon 2013-08-19 12:28:21 PM PDT] guys, are you sure it's not "DMA off stack" case? > [Mon 2013-08-19 12:28:35 PM PDT] it's a known stack corruptor on non-coherent arches > [Mon 2013-08-19 12:31:48 PM PDT] headless: for usb/ehci? > [Mon 2013-08-19 12:34:11 PM PDT] headless: explain > [Mon 2013-08-19 12:35:38 PM PDT] usb_control_msg() (or other such func) should not use buffer on stack. DMA from/to stack is prohibited > [Mon 2013-08-19 12:35:58 PM PDT] and EHCI uses DMA on control xfers (as well as all the others) > > Signed-off-by: Daniel Gimpelevich Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/