Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129Ab3HUWo6 (ORCPT ); Wed, 21 Aug 2013 18:44:58 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:55927 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953Ab3HUWo4 (ORCPT ); Wed, 21 Aug 2013 18:44:56 -0400 MIME-Version: 1.0 In-Reply-To: <20130821082811.GC29850@lee--X1> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-10-git-send-email-lee.jones@linaro.org> <20130821082811.GC29850@lee--X1> Date: Thu, 22 Aug 2013 00:44:55 +0200 Message-ID: Subject: Re: [PATCH 09/33] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 36 On Wed, Aug 21, 2013 at 10:28 AM, Lee Jones wrote: > On Tue, 20 Aug 2013, Linus Walleij wrote: >> On Thu, Jun 6, 2013 at 2:16 PM, Lee Jones wrote: >> >> > +++ b/arch/arm/boot/dts/dbx5x0.dtsi >> > @@ -572,6 +572,8 @@ >> > v-i2c-supply = <&db8500_vape_reg>; >> > >> > clock-frequency = <400000>; >> > + clocks = <&prcc_kclk 3 3>, <&prcc_pclk 3 3>; >> > + clock-names = "nmk-i2c.0", "apb_pclk"; >> >> To avoid confusing the clock name "nmk-i2c.0" with the device >> name in Linux of that device instance, can we use a name such >> that it is clear that this is not a dev_name match? >> >> "i2c0" works just fine as name I think? > > If you do that, then I think you need to change all of these too: > > git grep -e "\.0" -e "\.1" -e "\.2" -e "\.3" -- drivers/clk/ux500/ No, as I said in some other patch, all these clk_register_clkdev()s are unused in device tree boots and should not even be executed on the DT boot path. (But maybe you've proven me wrong there in this other thread ...) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/