Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337Ab3HVBZj (ORCPT ); Wed, 21 Aug 2013 21:25:39 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40410 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3HVBZi (ORCPT ); Wed, 21 Aug 2013 21:25:38 -0400 To: Joe Perches Cc: Zhi Yong Wu , linux-scsi@vger.kernel.org, James Bottomley , linux-kernel mlist , Zhi Yong Wu , akinobu.mita@gmail.com Subject: Re: [PATCH] scsi: fix the build warning From: "Martin K. Petersen" Organization: Oracle Corporation References: <1377132262-15744-1-git-send-email-zwu.kernel@gmail.com> <1377133329.12003.9.camel@joe-AO722> <1377134271.12003.15.camel@joe-AO722> Date: Wed, 21 Aug 2013 21:25:26 -0400 In-Reply-To: <1377134271.12003.15.camel@joe-AO722> (Joe Perches's message of "Wed, 21 Aug 2013 18:17:51 -0700") Message-ID: User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 18 >>>>> "Joe" == Joe Perches writes: Joe> I don't get this build warning in the first place and I think the Joe> scsi_debug file is quite old and probably doesn't need to be Joe> changed at all. guard isn't a boolean, it selects the checksum algorithm used. Also, I believe Akinobu's recent reorganization of this code in question fixed the warning. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/