Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564Ab3HVFmv (ORCPT ); Thu, 22 Aug 2013 01:42:51 -0400 Received: from a.mx.secunet.com ([195.81.216.161]:41845 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239Ab3HVFmt (ORCPT ); Thu, 22 Aug 2013 01:42:49 -0400 X-Greylist: delayed 1885 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Aug 2013 01:42:49 EDT Date: Thu, 22 Aug 2013 07:11:22 +0200 From: Steffen Klassert To: Chen Gang Cc: linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Message-ID: <20130822051122.GB26773@secunet.com> References: <5212E5E4.8010408@asianux.com> <5212E61F.7010602@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5212E61F.7010602@asianux.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 22 Aug 2013 05:11:22.0725 (UTC) FILETIME=[0B315950:01CE9EF6] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 22 On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote: > > If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED > share the same code. > > And do we need a comment "/* fall through */" between CPU_UP_CANCELED > and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ? > > At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share > the same code (if need a 'break'), or share the most of code (if "fall > through"). > CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for CPU_DOWN_PREPARE and CPU_UP_CANCELED. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/