Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753734Ab3HVLFI (ORCPT ); Thu, 22 Aug 2013 07:05:08 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:51270 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061Ab3HVLFG (ORCPT ); Thu, 22 Aug 2013 07:05:06 -0400 From: "Aneesh Kumar K.V" To: Joonsoo Kim Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li , Naoya Horiguchi , Hillf Danton Subject: Re: [PATCH v2 12/20] mm, hugetlb: remove vma_has_reserves() In-Reply-To: <20130822091747.GA22605@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> <1376040398-11212-13-git-send-email-iamjoonsoo.kim@lge.com> <87siy215e1.fsf@linux.vnet.ibm.com> <20130822091747.GA22605@lge.com> User-Agent: Notmuch/0.15.2+167~g5306b2b (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) Date: Thu, 22 Aug 2013 16:34:22 +0530 Message-ID: <87mwoa0yx5.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13082210-6102-0000-0000-0000040E95A7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2037 Lines: 54 Joonsoo Kim writes: > On Thu, Aug 22, 2013 at 02:14:38PM +0530, Aneesh Kumar K.V wrote: >> Joonsoo Kim writes: >> >> > vma_has_reserves() can be substituted by using return value of >> > vma_needs_reservation(). If chg returned by vma_needs_reservation() >> > is 0, it means that vma has reserves. Otherwise, it means that vma don't >> > have reserves and need a hugepage outside of reserve pool. This definition >> > is perfectly same as vma_has_reserves(), so remove vma_has_reserves(). >> > >> > Signed-off-by: Joonsoo Kim >> >> Reviewed-by: Aneesh Kumar K.V > > Thanks. > >> > @@ -580,8 +547,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h, >> > * have no page reserves. This check ensures that reservations are >> > * not "stolen". The child may still get SIGKILLed >> > */ >> > - if (!vma_has_reserves(vma, chg) && >> > - h->free_huge_pages - h->resv_huge_pages == 0) >> > + if (chg && h->free_huge_pages - h->resv_huge_pages == 0) >> > return NULL; >> > >> > /* If reserves cannot be used, ensure enough pages are in the pool */ >> > @@ -600,7 +566,7 @@ retry_cpuset: >> > if (page) { >> > if (avoid_reserve) >> > break; >> > - if (!vma_has_reserves(vma, chg)) >> > + if (chg) >> > break; >> > >> > SetPagePrivate(page); >> >> Can you add a comment above both the place to explain why checking chg >> is good enough ? > > Yes, I can. But it will be changed to use_reserve in patch 13 and it > represent it's meaning perfectly. So commeting may be useless. That should be ok, because having a comment in this patch helps in understanding the patch better, even though you are removing that later. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/