Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248Ab3HVMmq (ORCPT ); Thu, 22 Aug 2013 08:42:46 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:52587 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372Ab3HVMmp (ORCPT ); Thu, 22 Aug 2013 08:42:45 -0400 MIME-Version: 1.0 In-Reply-To: References: <1377132262-15744-1-git-send-email-zwu.kernel@gmail.com> <1377133329.12003.9.camel@joe-AO722> <1377134271.12003.15.camel@joe-AO722> Date: Thu, 22 Aug 2013 21:42:44 +0900 Message-ID: Subject: Re: [PATCH] scsi: fix the build warning From: Akinobu Mita To: "Martin K. Petersen" Cc: Joe Perches , Zhi Yong Wu , linux-scsi@vger.kernel.org, James Bottomley , linux-kernel mlist , Zhi Yong Wu , Paul Bolle , Douglas Gilbert Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 22 2013/8/22 Martin K. Petersen : >>>>>> "Joe" == Joe Perches writes: > > Joe> I don't get this build warning in the first place and I think the > Joe> scsi_debug file is quite old and probably doesn't need to be > Joe> changed at all. > > guard isn't a boolean, it selects the checksum algorithm used. > > Also, I believe Akinobu's recent reorganization of this code in question > fixed the warning. Unfortunately, this warning isn't fixed in linux-next, either. Paul Bolle also sent a patch that fixes the same warning in a little bit different way. http://marc.info/?l=linux-scsi&m=137404660520109&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/