Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176Ab3HVOtr (ORCPT ); Thu, 22 Aug 2013 10:49:47 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:65149 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631Ab3HVOtq (ORCPT ); Thu, 22 Aug 2013 10:49:46 -0400 MIME-Version: 1.0 In-Reply-To: <1377181627.2009.2.camel@dabdike.int.hansenpartnership.com> References: <1377132262-15744-1-git-send-email-zwu.kernel@gmail.com> <1377133329.12003.9.camel@joe-AO722> <1377134271.12003.15.camel@joe-AO722> <1377181627.2009.2.camel@dabdike.int.hansenpartnership.com> Date: Thu, 22 Aug 2013 23:49:45 +0900 Message-ID: Subject: Re: [PATCH] scsi: fix the build warning From: Akinobu Mita To: James Bottomley Cc: "Martin K. Petersen" , Joe Perches , Zhi Yong Wu , "linux-scsi@vger.kernel.org" , linux-kernel mlist , Zhi Yong Wu , Paul Bolle , Douglas Gilbert Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 30 2013/8/22 James Bottomley : > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: >> 2013/8/22 Martin K. Petersen : >> >>>>>> "Joe" == Joe Perches writes: >> > >> > Joe> I don't get this build warning in the first place and I think the >> > Joe> scsi_debug file is quite old and probably doesn't need to be >> > Joe> changed at all. >> > >> > guard isn't a boolean, it selects the checksum algorithm used. >> > >> > Also, I believe Akinobu's recent reorganization of this code in question >> > fixed the warning. >> >> Unfortunately, this warning isn't fixed in linux-next, either. >> Paul Bolle also sent a patch that fixes the same warning in a little >> bit different way. > > Well, it is and it isn't. Whether you see the warning seems to depend > on how gcc was built. My take is that an impossible default case just > to keep some versions of gcc quiet is a bit pointless. As Joe said in the other reply, scsi_debug_guard could be a negative value (scsi_debug_guard > 1 is only prohibited). So this warning does not seem a false positive. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/