Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019Ab3HVRaV (ORCPT ); Thu, 22 Aug 2013 13:30:21 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:59647 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787Ab3HVRaS (ORCPT ); Thu, 22 Aug 2013 13:30:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=zx2c4.com; h=mime-version :in-reply-to:references:date:message-id:subject:from:to:cc :content-type; q=dns; s=mail; b=kmlbE2q7uc+8nhOSWfiq+0HVPa4AKCev +IwvIcL3oEd5GJSQZ2naeaKk1J5HhIcHBMRjBTYJt68kzN5zYawBADfmGfhkdk5A QRcnNnmk6agmHmPnD8yEMV7erGLOmoHNk2hrJIRzGdNESiit+W1CN2ZUvJPahdh3 UOttbtA4CcA= MIME-Version: 1.0 In-Reply-To: <20130822153900.GA2878@srcf.ucam.org> References: <1377180132-4933-1-git-send-email-Jason@zx2c4.com> <1377180132-4933-3-git-send-email-Jason@zx2c4.com> <20130822153900.GA2878@srcf.ucam.org> Date: Thu, 22 Aug 2013 19:29:56 +0200 Message-ID: Subject: Re: [PATCH 3/3] thinkpad_acpi: Wire unused micmute LED to capslock From: "Jason A. Donenfeld" To: Matthew Garrett Cc: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, mjg@redhat.com, rjw@sisk.pl, len.brown@intel.com, dtor@insightbb.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 27 On Thu, Aug 22, 2013 at 5:39 PM, Matthew Garrett wrote: > I think there's a risk of user confusion here, in that it's now possible > for the mic mute light to be lit despite the internal microphone still > being active. That seems like surprising behaviour. Yeah, that is a legitimate concern. Patches 1/3 [1] and 2/3 [2] clearly make sense, as they're generic and don't really suggest any new behavior. But setting this behavior here as the default could indeed be a bit unexpected. I think it's fair to reject this patch (3/3), but accept the first two. Tweakers who have the same early boot caps-lock LED needs as me can simply put this in their initramfs after 1/3 and 2/3 are applied: # echo caps-lock > /sys/devices/platform/thinkpad_acpi/leds/tpacpi\:\:micmute/trigger Jason [1] https://lkml.org/lkml/2013/8/22/310 [2] https://lkml.org/lkml/2013/8/22/313 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/