Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031Ab3HVR5J (ORCPT ); Thu, 22 Aug 2013 13:57:09 -0400 Received: from phoenix3.szarvasnet.hu ([87.101.127.16]:35781 "EHLO mail.szarvasnet.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879Ab3HVR5H (ORCPT ); Thu, 22 Aug 2013 13:57:07 -0400 X-Greylist: delayed 435 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Aug 2013 13:57:07 EDT Message-ID: <52164F54.2070209@openwrt.org> Date: Thu, 22 Aug 2013 19:50:12 +0200 From: Gabor Juhos User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Julia Lawall CC: Ralf Baechle , kernel-janitors@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] MIPS: ath79: simplify platform_get_resource_byname/devm_ioremap_resource References: <1376902316-18520-1-git-send-email-Julia.Lawall@lip6.fr> <1376902316-18520-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1376902316-18520-7-git-send-email-Julia.Lawall@lip6.fr> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 33 2013.08.19. 10:51 keltez?ssel, Julia Lawall ?rta: > From: Julia Lawall > > Remove unneeded error handling on the result of a call to > platform_get_resource_byname when the value is passed to devm_ioremap_resource. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression pdev,res,e,e1; > expression ret != 0; > identifier l; > @@ > > res = platform_get_resource_byname(...); > - if (res == NULL) { ... \(goto l;\|return ret;\) } > e = devm_ioremap_resource(e1, res); > // > > Signed-off-by: Julia Lawall Acked-by: Gabor Juhos Thanks! -Gabor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/