Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754361Ab3HVUU4 (ORCPT ); Thu, 22 Aug 2013 16:20:56 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:33228 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077Ab3HVUUy (ORCPT ); Thu, 22 Aug 2013 16:20:54 -0400 Message-ID: <521672A1.6010202@wwwdotorg.org> Date: Thu, 22 Aug 2013 14:20:49 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Johannes Thumshirn CC: Rob Landley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog References: <1377088929-23694-1-git-send-email-johannes.thumshirn@men.de> <5214FA08.7090502@wwwdotorg.org> <20130822073740.GA3717@jtlinux> In-Reply-To: <20130822073740.GA3717@jtlinux> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 41 On 08/22/2013 01:37 AM, Johannes Thumshirn wrote: > On Wed, Aug 21, 2013 at 11:34:00AM -0600, Stephen Warren wrote: >> On 08/21/2013 06:42 AM, Johannes Thumshirn wrote: >>> I accidently put the devicetree bindings for the MEN A21 watchdog driver in >>> Documentation/devicetree/bindings/gpio instead of >>> Documentation/devicetree/bindings/watchdog, this patch addresses this error. >> >> The rename sounds fine, so that part, >> Acked-by: Stephen Warren >> >> However, the binding itself doesn't look right; it appears to have a >> single "gpios" property rather than using separate named xxx-gpios >> properties for different things... > > Ok, so I'll need something like the following? > > watchdog { > compatible ="men,a021-wdt"; > enable-gpios = <&gpio3 9 1>; /* WD_EN */ > fast-gpios = <&gpio3 10 1>; /* WD_FAST */ > trig-gpios = <&gpio3 11 1>; /* WD_TRIG */ > rst0-gpio = <&gpio3 6 1>; /* RST_CAUSE[0] */ > rst1-gpio = <&gpio3 7 1>; /* RST_CAUSE[1] */ > rst2-gpio = <&gpio3 8 1>; /* RST_CAUSE[2] */ > }; Yes, that looks more like what I'd expect, albeit I'd probably expect to see a rst-gpio property with 3 entries. > Or is there something like of_get_named_gpios(...) so I can put all 3 rst-gpios > into one property? A quick grep only revealed of_get_named_gpio(...). The availablity of APIs within Linux shouldn't impact the binding definitions. I would imagine it's easy enough to add of_get_named_gpio_by_index() or similar to Linux. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/