Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368Ab3HVUz2 (ORCPT ); Thu, 22 Aug 2013 16:55:28 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:62803 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753054Ab3HVUzZ (ORCPT ); Thu, 22 Aug 2013 16:55:25 -0400 Message-ID: <52167AB8.4060206@gmail.com> Date: Thu, 22 Aug 2013 13:55:20 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Rob Landley , Richard Weinberger CC: Geert Uytterhoeven , Sam Ravnborg , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel Subject: Re: [RFC] Get rid of SUBARCH References: <1377073172-3662-1-git-send-email-richard@nod.at> <20130821195157.GA18191@merkur.ravnborg.org> <1377204069.2737.108@driftwood> In-Reply-To: <1377204069.2737.108@driftwood> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 41 On 08/22/2013 01:41 PM, Rob Landley wrote: > On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote: >> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg wrote: >> >> > The series touches also m68k, sh, mips and unicore32. >> >> > These architectures magically select a cross compiler if ARCH != >> SUBARCH. >> >> > Do really need that behavior? >> >> >> >> This does remove functionality. >> >> It allows to build a kernel using e.g. "make ARCH=m68k". >> >> >> >> Perhaps this can be moved to generic code? Most (not all!) >> cross-toolchains >> >> are called $ARCH-{unknown-,}linux{,-gnu}. >> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux. >> > >> > Today you can specify CROSS_COMPILE in Kconfig. >> > With this we should be able to remove these hacks. >> >> The correct CROSS_COMPILE value depends on the host environment, not >> on the target configuration. > > Actually it depends on _both_. > I think the important issue is not the exact dependencies of the value of CROSS_COMPILE, but rather that it varies enough that automatically choosing a value based on SUBARCH often gives the wrong result. Removing SUBARCH and setting CROSS_COMPILE either from the make command line (or environment) or the config file, is a good idea because it simplifies the build system, makes things clearer, and yields more predictable results. David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/