Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 16 Oct 2002 05:32:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 16 Oct 2002 05:32:08 -0400 Received: from mail.hometree.net ([212.34.181.120]:4577 "EHLO mail.hometree.net") by vger.kernel.org with ESMTP id ; Wed, 16 Oct 2002 05:32:07 -0400 To: linux-kernel@vger.kernel.org Path: forge.intermeta.de!not-for-mail From: "Henning P. Schmiedehausen" Newsgroups: hometree.linux.kernel Subject: Re: [PATCH 2/3] Add extended attributes to ext2/3 Date: Wed, 16 Oct 2002 09:38:02 +0000 (UTC) Organization: INTERMETA - Gesellschaft fuer Mehrwertdienste mbH Message-ID: References: Reply-To: hps@intermeta.de NNTP-Posting-Host: forge.intermeta.de X-Trace: tangens.hometree.net 1034761082 25066 212.34.181.4 (16 Oct 2002 09:38:02 GMT) X-Complaints-To: news@intermeta.de NNTP-Posting-Date: Wed, 16 Oct 2002 09:38:02 +0000 (UTC) X-Copyright: (C) 1996-2002 Henning Schmiedehausen X-No-Archive: yes X-Newsreader: NN version 6.5.1 (NOV) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 21 tytso@mit.edu writes: >+ int ea_blocks = EXT3_I(inode)->i_file_acl ? >+ (inode->i_sb->s_blocksize >> 9) : 0; Sometimes I wonder if we shouldn't have the block size (512) and the bit shift (9) as defines somewhere and gradually shift away from hard coded values... If we ever decide to change the block size of ext2/ext3, we're in for a "looking for nines"... :-) Regards Henning -- Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer INTERMETA - Gesellschaft fuer Mehrwertdienste mbH hps@intermeta.de Am Schwabachgrund 22 Fon.: 09131 / 50654-0 info@intermeta.de D-91054 Buckenhof Fax.: 09131 / 50654-20 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/