Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636Ab3HWA04 (ORCPT ); Thu, 22 Aug 2013 20:26:56 -0400 Received: from co1ehsobe006.messaging.microsoft.com ([216.32.180.189]:14699 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753629Ab3HWA0z convert rfc822-to-8bit (ORCPT ); Thu, 22 Aug 2013 20:26:55 -0400 X-Forefront-Antispam-Report: CIP:149.199.60.83;KIP:(null);UIP:(null);IPV:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-SpamScore: -1 X-BigFish: VPS-1(zz98dIc89bh1418Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzzz2fh95h839h93fhd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h906i1155h192ch) Date: Thu, 22 Aug 2013 17:26:47 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Sebastian Hesselbarth CC: Mike Turquette , Russell King , Arnd Bergmann , Michal Simek , , Subject: Re: [RFC 17/17] clk: zynq: remove call to of_clk_init References: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> <1376964271-22715-18-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1376964271-22715-18-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-RCIS-Action: ALLOW Message-ID: Content-Transfer-Encoding: 8BIT X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 39 Hi Sebastian, On Tue, Aug 20, 2013 at 04:04:31AM +0200, Sebastian Hesselbarth wrote: > With arch/arm calling of_clk_init(NULL) from time_init(), we can now > remove it from corresponding drivers/clk code. I think that would break Zynq. If I see this correctly you call of_clk_init() from common code, _before_ the SOC specific time init function is called. The problem is, that we have code setting up a global pointer which is required by zynq_clk_setup() which is triggered when of_clk_init() is called. Let me try to illustrate the current call graph: time_init() zynq_timer_init() // this machines init_time() zynq_slcr_init() // setup System Level Control Registers including a global pointer zynq_clock_init() of_clk_init() zynq_clk_setup() // requires pointer setup in zynq_slcr_init() ... IIUC, your series would change this to: time_init() of_clk_init() zynq_clk_setup() // SLCR pointer is not setup/NULL ... zynq_timer_init() zynq_slcr_init() // now the pointer becomes valid Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/