Date: Thu, 22 Aug 2013 21:08:30 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        Hyeoncheol Lee <cheol.lee@lge.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 10/13] tracing/uprobes: Fetch args before reserving a
 ring buffer
Message-ID: <20130822210830.784fac63@gandalf.local.home>
In-Reply-To: <5216A55B.4030400@huawei.com>
References: <1376037909-17797-1-git-send-email-namhyung@kernel.org>
	<1376037909-17797-11-git-send-email-namhyung@kernel.org>
	<5204BCE6.2070102@hitachi.com>
	<20130822124212.328c09c7@gandalf.local.home>
	<5216A55B.4030400@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1367
Lines: 44

On Fri, 23 Aug 2013 07:57:15 +0800
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com> wrote:


> > 
> > What about creating a per cpu buffer when uprobes are registered, and
> > delete them when they are finished? Basically what trace_printk() does
> > if it detects that there are users of trace_printk() in the kernel.
> > Note, it does not deallocate them when finished, as it is never
> > finished until reboot ;-)
> > 
> > -- Steve
> >
> I also thought out this approach, but the issue is we cannot fetch user
> memory into per-cpu buffer, because use per-cpu buffer should under
> preempt disabled, and fetching user memory could sleep.

Actually, we could create a per_cpu mutex to match the per_cpu buffers.
This is not unlike what we do in -rt.

	int cpu;
	struct mutex *mutex;
	void *buf;


	/*
	 * Use per cpu buffers for fastest access, but we might migrate
	 * So the mutex makes sure we have sole access to it.
	 */

	cpu = raw_smp_processor_id();
	mutex = per_cpu(uprobe_cpu_mutex, cpu);
	buf = per_cpu(uprobe_cpu_buffer, cpu);

	mutex_lock(mutex);
	store_trace_args(..., buf,...);
	mutex_unlock(mutex);

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/