Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919Ab3HWC7T (ORCPT ); Thu, 22 Aug 2013 22:59:19 -0400 Received: from mail-bk0-f49.google.com ([209.85.214.49]:56668 "EHLO mail-bk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab3HWC7R (ORCPT ); Thu, 22 Aug 2013 22:59:17 -0400 MIME-Version: 1.0 Date: Fri, 23 Aug 2013 10:59:15 +0800 Message-ID: Subject: [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe() From: Wei Yongjun To: vinod.koul@intel.com, djbw@fb.com, grant.likely@linaro.org, rob.herring@calxeda.com Cc: yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 32 From: Wei Yongjun Fix to return -EINVAL in the irq parse and map error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/dma/cppi41.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c index 5dcebca..49ea05a 100644 --- a/drivers/dma/cppi41.c +++ b/drivers/dma/cppi41.c @@ -973,8 +973,10 @@ static int cppi41_dma_probe(struct platform_device *pdev) goto err_chans; irq = irq_of_parse_and_map(pdev->dev.of_node, 0); - if (!irq) + if (!irq) { + ret = -EINVAL; goto err_irq; + } cppi_writel(USBSS_IRQ_PD_COMP, cdd->usbss_mem + USBSS_IRQ_ENABLER); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/