Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709Ab3HWGQo (ORCPT ); Fri, 23 Aug 2013 02:16:44 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:50001 "EHLO LGEMRELSE6Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754506Ab3HWGQn (ORCPT ); Fri, 23 Aug 2013 02:16:43 -0400 X-AuditID: 9c930179-b7c0bae0000040ac-29-5216fe49ebf7 Date: Fri, 23 Aug 2013 15:16:53 +0900 From: Joonsoo Kim To: "Aneesh Kumar K.V" Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li , Naoya Horiguchi , Hillf Danton Subject: Re: [PATCH v2 12/20] mm, hugetlb: remove vma_has_reserves() Message-ID: <20130823061653.GC22605@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> <1376040398-11212-13-git-send-email-iamjoonsoo.kim@lge.com> <87siy215e1.fsf@linux.vnet.ibm.com> <20130822091747.GA22605@lge.com> <87mwoa0yx5.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mwoa0yx5.fsf@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2229 Lines: 56 On Thu, Aug 22, 2013 at 04:34:22PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > On Thu, Aug 22, 2013 at 02:14:38PM +0530, Aneesh Kumar K.V wrote: > >> Joonsoo Kim writes: > >> > >> > vma_has_reserves() can be substituted by using return value of > >> > vma_needs_reservation(). If chg returned by vma_needs_reservation() > >> > is 0, it means that vma has reserves. Otherwise, it means that vma don't > >> > have reserves and need a hugepage outside of reserve pool. This definition > >> > is perfectly same as vma_has_reserves(), so remove vma_has_reserves(). > >> > > >> > Signed-off-by: Joonsoo Kim > >> > >> Reviewed-by: Aneesh Kumar K.V > > > > Thanks. > > > >> > @@ -580,8 +547,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h, > >> > * have no page reserves. This check ensures that reservations are > >> > * not "stolen". The child may still get SIGKILLed > >> > */ > >> > - if (!vma_has_reserves(vma, chg) && > >> > - h->free_huge_pages - h->resv_huge_pages == 0) > >> > + if (chg && h->free_huge_pages - h->resv_huge_pages == 0) > >> > return NULL; > >> > > >> > /* If reserves cannot be used, ensure enough pages are in the pool */ > >> > @@ -600,7 +566,7 @@ retry_cpuset: > >> > if (page) { > >> > if (avoid_reserve) > >> > break; > >> > - if (!vma_has_reserves(vma, chg)) > >> > + if (chg) > >> > break; > >> > > >> > SetPagePrivate(page); > >> > >> Can you add a comment above both the place to explain why checking chg > >> is good enough ? > > > > Yes, I can. But it will be changed to use_reserve in patch 13 and it > > represent it's meaning perfectly. So commeting may be useless. > > That should be ok, because having a comment in this patch helps in > understanding the patch better, even though you are removing that > later. Okay. I will add it in next spin. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/