Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755165Ab3HWJLh (ORCPT ); Fri, 23 Aug 2013 05:11:37 -0400 Received: from mail.skyhub.de ([78.46.96.112]:52865 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569Ab3HWJLf (ORCPT ); Fri, 23 Aug 2013 05:11:35 -0400 Date: Fri, 23 Aug 2013 11:11:28 +0200 From: Borislav Petkov To: Vince Weaver Cc: Robert Richter , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , linux-kernel@vger.kernel.org, Robert Richter , Vince Weaver Subject: Re: [PATCH v3 12/12] [RFC] perf, persistent: ioctl functions to control persistency Message-ID: <20130823091128.GA19548@nazgul.tnic> References: <1377180807-12758-1-git-send-email-rric@kernel.org> <1377180807-12758-13-git-send-email-rric@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 29 On Thu, Aug 22, 2013 at 02:18:06PM -0400, Vince Weaver wrote: > > PERF_EVENT_IOC_ATTACH (Since Linux 3.xx) > > PERF_EVENT_IOC_DETACH (Since Linux 3.xx) > > I think these aren't very good names for the ioctls. Maybe something > like > PERF_EVENT_IOC_MAKE_PERSISTENT > PERF_EVENT_IOC_UNPERSIST > I know that last one's not a real word but I can't think of what the > proper term would be. Maybe > PERF_EVENT_IOC_RELEASE_PERSISTENT > PERF_EVENT_IOC_RECLAIM_PERSISTENT "aren't very good names" is not really an argument I can work with. Why not? What if you want to attach/detach to events but not be persistent. Which also begs the question how long are we persistent? The whole system runtime or until the user decides to detach. So ATTACH/DETACH in the sense of attaching processes to events for an arbitrary amount of time *and* *not* for the duration of the tracee as we do it currently implicitly, is much more generic wrt usage than specifying that specific persistent case. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/