Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 16 Oct 2002 07:25:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 16 Oct 2002 07:25:10 -0400 Received: from thebsh.namesys.com ([212.16.7.65]:19728 "HELO thebsh.namesys.com") by vger.kernel.org with SMTP id ; Wed, 16 Oct 2002 07:25:08 -0400 From: Nikita Danilov MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15789.19959.929002.906160@laputa.namesys.com> Date: Wed, 16 Oct 2002 15:31:03 +0400 X-PGP-Fingerprint: 43CE 9384 5A1D CD75 5087 A876 A1AA 84D0 CCAA AC92 X-PGP-Key-ID: CCAAAC92 X-PGP-Key-At: http://wwwkeys.pgp.net:11371/pks/lookup?op=get&search=0xCCAAAC92 To: Geert Uytterhoeven Cc: Linux Kernel Development , linux-xfs@oss.sgi.com Subject: Re: XFS build error on m68k in 2.5.43 In-Reply-To: References: X-Mailer: VM 7.07 under 21.5 (beta6) "bok choi" XEmacs Lucid Tomato: Beige Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 33 Geert Uytterhoeven writes: > > When compiling a kernel for m68k (with CONFIG_XFS_FS=m), I get this error: > > | make -f fs/xfs/Makefile > | rm -f fs/xfs/built-in.o; m68k-linux-ar rcs fs/xfs/built-in.o > | m68k-linux-gcc -Wp,-MD,fs/xfs/linux/.xfs_stats.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -fno-strength-reduce -ffixed-a2 -nostdinc -iwithprefix include -DMODULE -Ifs/xfs -funsigned-char -DKBUILD_BASENAME=xfs_stats -c -o fs/xfs/linux/xfs_stats.o fs/xfs/linux/xfs_stats.c > | In file included from fs/xfs/xfs.h:70, > | from fs/xfs/linux/xfs_stats.c:33: > | fs/xfs/xfs_bmap_btree.h:662: badly punctuated parameter list in `#define' > | fs/xfs/xfs_log.h:62: warning: `_lsn_cmp' defined but not used > | make[2]: *** [fs/xfs/linux/xfs_stats.o] Error 1 > | make[1]: *** [fs/xfs] Error 2 > | make: *** [fs] Error 2 > > Since it's not obvious to me what's wrong with that define, I'm asking here. Second parameter of xfs_bmbt_disk_set_allf is 0 (zero). Try to replace it with O. > > Gr{oetje,eeting}s, > > Geert Nikita. > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/