Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755124Ab3HWKEF (ORCPT ); Fri, 23 Aug 2013 06:04:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:46234 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755075Ab3HWKED (ORCPT ); Fri, 23 Aug 2013 06:04:03 -0400 Date: Fri, 23 Aug 2013 12:03:40 +0200 From: Peter Zijlstra To: Preeti U Murthy Cc: Ingo Molnar , Joonsoo Kim , linux-kernel@vger.kernel.org, Mike Galbraith , Paul Turner , Alex Shi , Vincent Guittot , Morten Rasmussen , Namhyung Kim , Lei Wen , Rik van Riel , Joonsoo Kim Subject: Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue() Message-ID: <20130823100340.GP31370@twins.programming.kicks-ass.net> References: <20130819160058.539049611@infradead.org> <20130819160425.527872672@infradead.org> <5217194B.2020209@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5217194B.2020209@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 17 On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: > Hi Peter, > > On 08/19/2013 09:31 PM, Peter Zijlstra wrote: > > In the load balancing code, looks to me that > cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, > before calling find_busiest_group(). Am I missing something? > > Should not cpumask_copy() below be before we update the env.cpus parameter? Nah, its all pointers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/