From: Weijie Yang <weijie.yang@samsung.com>
To: minchan@kernel.org, bob.liu@oracle.com, sjenning@linux.vnet.ibm.com
Cc: weijie.yang.kh@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] zswap bugfix: memory leaks and other problem
Date: Fri, 23 Aug 2013 18:12:33 +0800
Message-id: <000101ce9fe9$6849dab0$38dd9010$%yang@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 8BIT
Thread-index: Ac6f6Uh4QigShxGCRRedbD037w4JRA==
Content-language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1600
Lines: 33

This patch series fix a few bugs in zswap based on Linux-3.11-rc6.

Corresponding mail thread see: lkml.org/lkml/2013/8/18/59 .

These issues fixed are:
1. memory leaks when re-swapon
2. potential problem which store and reclaim functions is called recursively 
3. memory leaks when invalidate and reclaim occur simultaneously 
4. unnecessary page scanning

Issues discussed in that mail thread NOT fixed as it happens rarely or not a big problem:
1. a "theoretical race condition" when reclaim page 
when a handle alloced from zbud, zbud considers this handle is used validly by upper(zswap) and can be a candidate for reclaim.
But zswap has to initialize it such as setting swapentry and adding it to rbtree. so there is a race condition, such as:
thread 0: obtain handle x from zbud_alloc 
thread 1: zbud_reclaim_page is called 
thread 1: callback zswap_writeback_entry to reclaim handle x 
thread 1: get swpentry from handle x (it is random value now) 
thread 1: bad thing may happen 
thread 0: initialize handle x with swapentry

2. frontswap_map bitmap not cleared after zswap reclaim 
Frontswap uses frontswap_map bitmap to track page in "backend" implementation, 
when zswap reclaim a page, the corresponding bitmap record is not cleared.

mm/zswap.c |   35 ++++++++++++++++++++++++-----------
 1 files changed, 24 insertions(+), 11 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/