Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755435Ab3HWKox (ORCPT ); Fri, 23 Aug 2013 06:44:53 -0400 Received: from a.mx.secunet.com ([195.81.216.161]:60995 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755054Ab3HWKou (ORCPT ); Fri, 23 Aug 2013 06:44:50 -0400 Date: Fri, 23 Aug 2013 12:44:48 +0200 From: Steffen Klassert To: Chen Gang , Herbert Xu Cc: linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Message-ID: <20130823104448.GI26773@secunet.com> References: <5212E5E4.8010408@asianux.com> <5212E61F.7010602@asianux.com> <20130822051122.GB26773@secunet.com> <5215A134.90607@asianux.com> <20130822060503.GC26773@secunet.com> <5215B319.3020908@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5215B319.3020908@asianux.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 23 Aug 2013 10:44:48.0803 (UTC) FILETIME=[CA285730:01CE9FED] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 20 On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote: > Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to > CPU_DOWN_PREPARE and CPU_UP_CANCELED. > > It will fix 2 bugs: > > "not check the return value of __padata_remove_cpu() and __padata_add_cpu()". > "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED". > > > Signed-off-by: Chen Gang This looks ok to me, Herbert can you take this one? Acked-by: Steffen Klassert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/