Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753Ab3HWOep (ORCPT ); Fri, 23 Aug 2013 10:34:45 -0400 Received: from top.free-electrons.com ([176.31.233.9]:50687 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753605Ab3HWOeo (ORCPT ); Fri, 23 Aug 2013 10:34:44 -0400 Message-ID: <52177301.1060803@free-electrons.com> Date: Fri, 23 Aug 2013 16:34:41 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 08/17] ARM: mvebu: remove custom .init_time hook References: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> <1376964271-22715-9-git-send-email-sebastian.hesselbarth@gmail.com> <52173408.1000702@free-electrons.com> <52173A3E.2040509@gmail.com> <521749E5.6020008@free-electrons.com> <521751E9.3000504@gmail.com> <52177047.9070706@free-electrons.com> In-Reply-To: <52177047.9070706@free-electrons.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2561 Lines: 68 On 23/08/2013 16:23, Gregory CLEMENT wrote: > On 23/08/2013 14:13, Sebastian Hesselbarth wrote: >> On 08/23/13 13:39, Gregory CLEMENT wrote: >>> On 23/08/2013 12:32, Sebastian Hesselbarth wrote: >>>> On 08/23/13 12:06, Gregory CLEMENT wrote: >>>>> On 20/08/2013 04:04, Sebastian Hesselbarth wrote: >>>>>> With arch/arm calling of_clk_init(NULL) from time_init(), we can now >>>>>> remove custom .init_time hooks. >>>>> >>>>> As a feared it won't work on Armada XP. You moved coherency_init(), and >>>>> l2x0_of_init() in the init_machine hook. However init_machine is an >>>>> arch_initcall, and as all the initcall it is called at the end of the >>>>> do_basic_setup() which is called after smp_prepare_cpus(). The issue is >>>>> that smp_prepare_cpus need coherency (and I think L2 cache) already enable. >>>> >>>> Ok, I see. I remember mvebu smp relies on mbus mappings also? Can you >>>> try below as replacement for the mach-mvebu/armada-370-xp.c changes? >>>> >>>> It will move coherency_init(), l2x0_of_init(), and mvebu_mbus_dt_init() >>>> to .init_early hook. >>>> >>> >>> I can't test it, because I don't receive the patch 1 and 2 neither directly >>> or through linux-arm-kernel (it should have been bounced), or even at >>> https://github.com/shesselba/linux-dove.git >>> >>> If you don't want to send them again, could you at least push our branch on your >>> github? >> >> Gregory, >> >> I pushed a branch containing the latest state to >> https://github.com/shesselba/linux-dove.git arm-clk-of-init >> >> It still contains the changes to drivers/clk.c, that will become >> obsolete, if there are no objections against Stephen's tegra patch. >> > > I tested your branch on my Armada XP boards (the GP and the AX3), and it hanged > very early: before that anything was displayed by the early_printk! > > init_early is maybe called too early :( Well actually next-20130822 don't boot. So I can't say if your changes are ok. > >> Sebastian >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/