Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755532Ab3HWOgr (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Aug 2013 10:36:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26693 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753645Ab3HWOgq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Aug 2013 10:36:46 -0400
Date: Fri, 23 Aug 2013 10:36:38 -0400
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>,
        Fengguang Wu <fengguang.wu@intel.com>, Tony Luck <tony.luck@intel.com>,
        gong.chen@linux.intel.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Message-ID: <1377268598-md0gqi8g-mutt-n-horiguchi@ah.jp.nec.com>
In-Reply-To: <1377253841-17620-5-git-send-email-liwanp@linux.vnet.ibm.com>
References: <1377253841-17620-1-git-send-email-liwanp@linux.vnet.ibm.com>
 <1377253841-17620-5-git-send-email-liwanp@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 5/7] mm/hwpoison: don't set migration type twice to
 avoid hold heavy contend zone->lock
Mime-Version: 1.0
Content-Type: text/plain;
 charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Mutt-References: <1377253841-17620-5-git-send-email-liwanp@linux.vnet.ibm.com>
X-Mutt-Fcc: ~/Maildir/sent/
User-Agent: Mutt 1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2221
Lines: 55

On Fri, Aug 23, 2013 at 06:30:39PM +0800, Wanpeng Li wrote:
> v1 -> v2:
> 	* add more explanation in patch description.
> 
> Set pageblock migration type will hold zone->lock which is heavy contended
> in system to avoid race. However, soft offline page will set pageblock
> migration type twice during get page if the page is in used, not hugetlbfs
> page and not on lru list. There is unnecessary to set the pageblock migration
> type and hold heavy contended zone->lock again if the first round get page
> have already set the pageblock to right migration type.
> 
> The trick here is migration type is MIGRATE_ISOLATE. There are other two parts 
> can change MIGRATE_ISOLATE except hwpoison. One is memory hoplug, however, we 
> hold lock_memory_hotplug() which avoid race. The second is CMA which umovable 
> page allocation requst can't fallback to. So it's safe here.
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> ---
>  mm/memory-failure.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 297965e..f357c91 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1426,7 +1426,8 @@ static int __get_any_page(struct page *p, unsigned long pfn, int flags)
>  	 * was free. This flag should be kept set until the source page
>  	 * is freed and PG_hwpoison on it is set.
>  	 */
> -	set_migratetype_isolate(p, true);
> +	if (get_pageblock_migratetype(p) == MIGRATE_ISOLATE)
> +		set_migratetype_isolate(p, true);

Do you really mean "we set MIGRATE_ISOLATE only if it's already set?"

Thanks,
Naoya Horiguchi

>  	/*
>  	 * When the target page is a free hugepage, just remove it
>  	 * from free hugepage list.
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/