Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756000Ab3HWSCB (ORCPT ); Fri, 23 Aug 2013 14:02:01 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:53654 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755838Ab3HWSCA (ORCPT ); Fri, 23 Aug 2013 14:02:00 -0400 MIME-Version: 1.0 In-Reply-To: <20130822092130.GB22023@lee--X1> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-22-git-send-email-lee.jones@linaro.org> <20130821101448.GJ29850@lee--X1> <20130822092130.GB22023@lee--X1> Date: Fri, 23 Aug 2013 20:01:59 +0200 Message-ID: Subject: Re: [PATCH 21/33] clk: ux500: Add Device Tree support for the PRCC Kernel clock From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Mike Turquette , Ulf Hansson Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 36 On Thu, Aug 22, 2013 at 11:21 AM, Lee Jones wrote: >> I really do not like the approach of uglifying something and then >> beautifying it later... I prefer each step in isolation to be good >> looking, or you will be confused when traversing the history. > > So then we have a few options, some more realistic than others. > > 1. Duplicate each of the; clk_reg_prcmu_*(), clk_reg_prcc_pclk(), > clk_reg_prcc_kclk() calls into your proposed u8500_clk_init_dt(), > which, while keeping everything separate would be unrealistic. I think this is perfectly realistic. You're not going to duplicate each clk_register_clkdev(), which makes it way smaller than the original function, and since one of the function will be inside a #ifdef CONFIG_OF #endif After we switch the entire platform to DT-only it will be pretty obvious which big chunk of code that needs to go away, it's a clean cut. (Note: I know the #ifdef CONFIG_OF is not necessary anymore since we switched to multiplatform, but I intend that marker for humans, not machines.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/