Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756231Ab3HWTEE (ORCPT ); Fri, 23 Aug 2013 15:04:04 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:51264 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755621Ab3HWTEC (ORCPT ); Fri, 23 Aug 2013 15:04:02 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376189294-32022-1-git-send-email-yinghai@kernel.org> <1376189294-32022-29-git-send-email-yinghai@kernel.org> Date: Fri, 23 Aug 2013 12:04:01 -0700 X-Google-Sender-Auth: a0clahp2i0V1bkeVcPJKAsJLPgk Message-ID: Subject: Re: [PATCH v4 28/28] PCI, x86, ACPI: get ioapic address from acpi device From: Yinghai Lu To: Lan Tianyu , "Rafael J. Wysocki" , Bjorn Helgaas Cc: rui wang , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Linux PCI , "linux-kernel@vger kernel org" , "linux-acpi@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 33 On Fri, Aug 23, 2013 at 11:38 AM, Yinghai Lu wrote: > On Fri, Aug 23, 2013 at 8:34 AM, Lan Tianyu wrote: >>> I worked around the problem by replacing acpi_resource_to_address64() >>> with resource_to_addr(). But resource_to_addr() is a static function >>> in arch/x86/pci/acpi.c, not very convenient to use. Here's what I did: >>> >> >> Hi Rui&Yinghai: >> How about using the following code to translate struct >> acpi_resource to struct resouce in this setup_res()? >> >> if (acpi_dev_resource_address_space(...) >> || acpi_dev_resource_memory(..)) >> return AE_OK; > > Yest, that could be better, will update that. > > Also can you submit patch that will use that in res_to_addr of > arch/x86/pci/acpi.c? looks acpi_dev_resource_address_space... does not handle PREFTCH and translation offset. So now i have to use res_to_addr alike one. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/