Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756188Ab3HWTix (ORCPT ); Fri, 23 Aug 2013 15:38:53 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:41609 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755021Ab3HWTit (ORCPT ); Fri, 23 Aug 2013 15:38:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376189294-32022-1-git-send-email-yinghai@kernel.org> <1376189294-32022-29-git-send-email-yinghai@kernel.org> Date: Fri, 23 Aug 2013 12:38:48 -0700 X-Google-Sender-Auth: vVU8nWU1K5SIyOHslLU9MXoaTNc Message-ID: Subject: Re: [PATCH v4 28/28] PCI, x86, ACPI: get ioapic address from acpi device From: Yinghai Lu To: Lan Tianyu , "Rafael J. Wysocki" , Bjorn Helgaas Cc: rui wang , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Linux PCI , "linux-kernel@vger kernel org" , "linux-acpi@vger.kernel.org" Content-Type: multipart/mixed; boundary=e89a8ff2528a3944e504e4a28e09 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 9521 Lines: 152 --e89a8ff2528a3944e504e4a28e09 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Aug 23, 2013 at 12:04 PM, Yinghai Lu wrote: > On Fri, Aug 23, 2013 at 11:38 AM, Yinghai Lu wrote: >> On Fri, Aug 23, 2013 at 8:34 AM, Lan Tianyu wrote: >>>> I worked around the problem by replacing acpi_resource_to_address64() >>>> with resource_to_addr(). But resource_to_addr() is a static function >>>> in arch/x86/pci/acpi.c, not very convenient to use. Here's what I did: >>>> >>> >>> Hi Rui&Yinghai: >>> How about using the following code to translate struct >>> acpi_resource to struct resouce in this setup_res()? >>> >>> if (acpi_dev_resource_address_space(...) >>> || acpi_dev_resource_memory(..)) >>> return AE_OK; >> >> Yest, that could be better, will update that. >> >> Also can you submit patch that will use that in res_to_addr of >> arch/x86/pci/acpi.c? > > looks acpi_dev_resource_address_space... does not handle > PREFTCH and translation offset. > > So now i have to use res_to_addr alike one. Raphael, Maybe we should move resource_to_addr to acpi generic. Please check if you are ok with attached. Thanks Yinghai --e89a8ff2528a3944e504e4a28e09 Content-Type: application/octet-stream; name="move_res_to_addr.patch" Content-Disposition: attachment; filename="move_res_to_addr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hkpsy5m60 U3ViamVjdDogW1BBVENIXSBBQ1BJLCB4ODYvUENJOiBNb3ZlIHJlc291cmNlX3RvX2FkZHIoKSB0 byBhY3BpIGdlbmVyaWMKClJ1aSB3YW5nIHJlcG9ydGVkIGlvYXBpYyBob3QtYWRkIGRvZXMgbm90 IHdvcmsgb24gaGlzIG1hY2hpbmUKdGhhdCBfQ1JTIGhhdmUgTUVNT1JZX0ZJWEVELgpIZSBhbHNv IHByb3Bvc2VkIHRvIGV4cG9zZSByZXNvdXJjZV90b19hZGRyKCkgYW5kIHVzZSBpdCBmb3IgaW9h cGljLgoKV2Ugc2hvdWxkIG1vdmUgaXQgdG8gYWNwaSBnZW5lcmljLCBhcyBpb2FwaS5jIGN1cnJl bnQgaXMgaW4KZHJpdmVycy9wY2kvLgoKT3Igc2hvdWxkIG1vdmUgaXQgdG8gYWNwaWNhPwoKU2ln bmVkLW9mZi1ieTogWWluZ2hhaSBMdSA8eWluZ2hhaUBrZXJuZWwub3JnPgoKLS0tCiBhcmNoL3g4 Ni9wY2kvYWNwaS5jICAgICB8ICAgNTEgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiBkcml2ZXJzL2FjcGkvcmVzb3VyY2UuYyB8ICAgNDYgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogaW5jbHVkZS9saW51eC9hY3BpLmgg ICAgfCAgICAzICsrCiAzIGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDQ5IGRlbGV0 aW9ucygtKQoKSW5kZXg6IGxpbnV4LTIuNi9hcmNoL3g4Ni9wY2kvYWNwaS5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGxpbnV4LTIuNi5vcmlnL2FyY2gveDg2L3BjaS9hY3BpLmMKKysrIGxpbnV4LTIuNi9hcmNo L3g4Ni9wY2kvYWNwaS5jCkBAIC0yMTksNjAgKzIxOSwxMyBAQCBzdGF0aWMgdm9pZCB0ZWFyZG93 bl9tY2ZnX21hcChzdHJ1Y3QgcGNpCiAjZW5kaWYKIAogc3RhdGljIGFjcGlfc3RhdHVzCi1yZXNv dXJjZV90b19hZGRyKHN0cnVjdCBhY3BpX3Jlc291cmNlICpyZXNvdXJjZSwKLQkJCXN0cnVjdCBh Y3BpX3Jlc291cmNlX2FkZHJlc3M2NCAqYWRkcikKLXsKLQlhY3BpX3N0YXR1cyBzdGF0dXM7Ci0J c3RydWN0IGFjcGlfcmVzb3VyY2VfbWVtb3J5MjQgKm1lbW9yeTI0OwotCXN0cnVjdCBhY3BpX3Jl c291cmNlX21lbW9yeTMyICptZW1vcnkzMjsKLQlzdHJ1Y3QgYWNwaV9yZXNvdXJjZV9maXhlZF9t ZW1vcnkzMiAqZml4ZWRfbWVtb3J5MzI7Ci0KLQltZW1zZXQoYWRkciwgMCwgc2l6ZW9mKCphZGRy KSk7Ci0Jc3dpdGNoIChyZXNvdXJjZS0+dHlwZSkgewotCWNhc2UgQUNQSV9SRVNPVVJDRV9UWVBF X01FTU9SWTI0OgotCQltZW1vcnkyNCA9ICZyZXNvdXJjZS0+ZGF0YS5tZW1vcnkyNDsKLQkJYWRk ci0+cmVzb3VyY2VfdHlwZSA9IEFDUElfTUVNT1JZX1JBTkdFOwotCQlhZGRyLT5taW5pbXVtID0g bWVtb3J5MjQtPm1pbmltdW07Ci0JCWFkZHItPmFkZHJlc3NfbGVuZ3RoID0gbWVtb3J5MjQtPmFk ZHJlc3NfbGVuZ3RoOwotCQlhZGRyLT5tYXhpbXVtID0gYWRkci0+bWluaW11bSArIGFkZHItPmFk ZHJlc3NfbGVuZ3RoIC0gMTsKLQkJcmV0dXJuIEFFX09LOwotCWNhc2UgQUNQSV9SRVNPVVJDRV9U WVBFX01FTU9SWTMyOgotCQltZW1vcnkzMiA9ICZyZXNvdXJjZS0+ZGF0YS5tZW1vcnkzMjsKLQkJ YWRkci0+cmVzb3VyY2VfdHlwZSA9IEFDUElfTUVNT1JZX1JBTkdFOwotCQlhZGRyLT5taW5pbXVt ID0gbWVtb3J5MzItPm1pbmltdW07Ci0JCWFkZHItPmFkZHJlc3NfbGVuZ3RoID0gbWVtb3J5MzIt PmFkZHJlc3NfbGVuZ3RoOwotCQlhZGRyLT5tYXhpbXVtID0gYWRkci0+bWluaW11bSArIGFkZHIt PmFkZHJlc3NfbGVuZ3RoIC0gMTsKLQkJcmV0dXJuIEFFX09LOwotCWNhc2UgQUNQSV9SRVNPVVJD RV9UWVBFX0ZJWEVEX01FTU9SWTMyOgotCQlmaXhlZF9tZW1vcnkzMiA9ICZyZXNvdXJjZS0+ZGF0 YS5maXhlZF9tZW1vcnkzMjsKLQkJYWRkci0+cmVzb3VyY2VfdHlwZSA9IEFDUElfTUVNT1JZX1JB TkdFOwotCQlhZGRyLT5taW5pbXVtID0gZml4ZWRfbWVtb3J5MzItPmFkZHJlc3M7Ci0JCWFkZHIt PmFkZHJlc3NfbGVuZ3RoID0gZml4ZWRfbWVtb3J5MzItPmFkZHJlc3NfbGVuZ3RoOwotCQlhZGRy LT5tYXhpbXVtID0gYWRkci0+bWluaW11bSArIGFkZHItPmFkZHJlc3NfbGVuZ3RoIC0gMTsKLQkJ cmV0dXJuIEFFX09LOwotCWNhc2UgQUNQSV9SRVNPVVJDRV9UWVBFX0FERFJFU1MxNjoKLQljYXNl IEFDUElfUkVTT1VSQ0VfVFlQRV9BRERSRVNTMzI6Ci0JY2FzZSBBQ1BJX1JFU09VUkNFX1RZUEVf QUREUkVTUzY0OgotCQlzdGF0dXMgPSBhY3BpX3Jlc291cmNlX3RvX2FkZHJlc3M2NChyZXNvdXJj ZSwgYWRkcik7Ci0JCWlmIChBQ1BJX1NVQ0NFU1Moc3RhdHVzKSAmJgotCQkgICAgKGFkZHItPnJl c291cmNlX3R5cGUgPT0gQUNQSV9NRU1PUllfUkFOR0UgfHwKLQkJICAgIGFkZHItPnJlc291cmNl X3R5cGUgPT0gQUNQSV9JT19SQU5HRSkgJiYKLQkJICAgIGFkZHItPmFkZHJlc3NfbGVuZ3RoID4g MCkgewotCQkJcmV0dXJuIEFFX09LOwotCQl9Ci0JCWJyZWFrOwotCX0KLQlyZXR1cm4gQUVfRVJS T1I7Ci19Ci0KLXN0YXRpYyBhY3BpX3N0YXR1cwogY291bnRfcmVzb3VyY2Uoc3RydWN0IGFjcGlf cmVzb3VyY2UgKmFjcGlfcmVzLCB2b2lkICpkYXRhKQogewogCXN0cnVjdCBwY2lfcm9vdF9pbmZv ICppbmZvID0gZGF0YTsKIAlzdHJ1Y3QgYWNwaV9yZXNvdXJjZV9hZGRyZXNzNjQgYWRkcjsKIAlh Y3BpX3N0YXR1cyBzdGF0dXM7CiAKLQlzdGF0dXMgPSByZXNvdXJjZV90b19hZGRyKGFjcGlfcmVz LCAmYWRkcik7CisJc3RhdHVzID0gYWNwaV9tZW1fYWRkcl9yZXNvdXJjZV90b19hZGRyZXNzNjQo YWNwaV9yZXMsICZhZGRyKTsKIAlpZiAoQUNQSV9TVUNDRVNTKHN0YXR1cykpCiAJCWluZm8tPnJl c19udW0rKzsKIAlyZXR1cm4gQUVfT0s7CkBAIC0yODgsNyArMjQxLDcgQEAgc2V0dXBfcmVzb3Vy Y2Uoc3RydWN0IGFjcGlfcmVzb3VyY2UgKmFjcAogCXVuc2lnbmVkIGxvbmcgZmxhZ3M7CiAJdTY0 IHN0YXJ0LCBvcmlnX2VuZCwgZW5kOwogCi0Jc3RhdHVzID0gcmVzb3VyY2VfdG9fYWRkcihhY3Bp X3JlcywgJmFkZHIpOworCXN0YXR1cyA9IGFjcGlfbWVtX2FkZHJfcmVzb3VyY2VfdG9fYWRkcmVz czY0KGFjcGlfcmVzLCAmYWRkcik7CiAJaWYgKCFBQ1BJX1NVQ0NFU1Moc3RhdHVzKSkKIAkJcmV0 dXJuIEFFX09LOwogCkluZGV4OiBsaW51eC0yLjYvZHJpdmVycy9hY3BpL3Jlc291cmNlLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gbGludXgtMi42Lm9yaWcvZHJpdmVycy9hY3BpL3Jlc291cmNlLmMKKysrIGxp bnV4LTIuNi9kcml2ZXJzL2FjcGkvcmVzb3VyY2UuYwpAQCAtNDE0LDYgKzQxNCw1MiBAQCB2b2lk IGFjcGlfZGV2X2ZyZWVfcmVzb3VyY2VfbGlzdChzdHJ1Y3QKIH0KIEVYUE9SVF9TWU1CT0xfR1BM KGFjcGlfZGV2X2ZyZWVfcmVzb3VyY2VfbGlzdCk7CiAKK2FjcGlfc3RhdHVzIGFjcGlfbWVtX2Fk ZHJfcmVzb3VyY2VfdG9fYWRkcmVzczY0KHN0cnVjdCBhY3BpX3Jlc291cmNlICpyZXNvdXJjZSwK KwkJCXN0cnVjdCBhY3BpX3Jlc291cmNlX2FkZHJlc3M2NCAqYWRkcikKK3sKKwlhY3BpX3N0YXR1 cyBzdGF0dXM7CisJc3RydWN0IGFjcGlfcmVzb3VyY2VfbWVtb3J5MjQgKm1lbW9yeTI0OworCXN0 cnVjdCBhY3BpX3Jlc291cmNlX21lbW9yeTMyICptZW1vcnkzMjsKKwlzdHJ1Y3QgYWNwaV9yZXNv dXJjZV9maXhlZF9tZW1vcnkzMiAqZml4ZWRfbWVtb3J5MzI7CisKKwltZW1zZXQoYWRkciwgMCwg c2l6ZW9mKCphZGRyKSk7CisJc3dpdGNoIChyZXNvdXJjZS0+dHlwZSkgeworCWNhc2UgQUNQSV9S RVNPVVJDRV9UWVBFX01FTU9SWTI0OgorCQltZW1vcnkyNCA9ICZyZXNvdXJjZS0+ZGF0YS5tZW1v cnkyNDsKKwkJYWRkci0+cmVzb3VyY2VfdHlwZSA9IEFDUElfTUVNT1JZX1JBTkdFOworCQlhZGRy LT5taW5pbXVtID0gbWVtb3J5MjQtPm1pbmltdW07CisJCWFkZHItPmFkZHJlc3NfbGVuZ3RoID0g bWVtb3J5MjQtPmFkZHJlc3NfbGVuZ3RoOworCQlhZGRyLT5tYXhpbXVtID0gYWRkci0+bWluaW11 bSArIGFkZHItPmFkZHJlc3NfbGVuZ3RoIC0gMTsKKwkJcmV0dXJuIEFFX09LOworCWNhc2UgQUNQ SV9SRVNPVVJDRV9UWVBFX01FTU9SWTMyOgorCQltZW1vcnkzMiA9ICZyZXNvdXJjZS0+ZGF0YS5t ZW1vcnkzMjsKKwkJYWRkci0+cmVzb3VyY2VfdHlwZSA9IEFDUElfTUVNT1JZX1JBTkdFOworCQlh ZGRyLT5taW5pbXVtID0gbWVtb3J5MzItPm1pbmltdW07CisJCWFkZHItPmFkZHJlc3NfbGVuZ3Ro ID0gbWVtb3J5MzItPmFkZHJlc3NfbGVuZ3RoOworCQlhZGRyLT5tYXhpbXVtID0gYWRkci0+bWlu aW11bSArIGFkZHItPmFkZHJlc3NfbGVuZ3RoIC0gMTsKKwkJcmV0dXJuIEFFX09LOworCWNhc2Ug QUNQSV9SRVNPVVJDRV9UWVBFX0ZJWEVEX01FTU9SWTMyOgorCQlmaXhlZF9tZW1vcnkzMiA9ICZy ZXNvdXJjZS0+ZGF0YS5maXhlZF9tZW1vcnkzMjsKKwkJYWRkci0+cmVzb3VyY2VfdHlwZSA9IEFD UElfTUVNT1JZX1JBTkdFOworCQlhZGRyLT5taW5pbXVtID0gZml4ZWRfbWVtb3J5MzItPmFkZHJl c3M7CisJCWFkZHItPmFkZHJlc3NfbGVuZ3RoID0gZml4ZWRfbWVtb3J5MzItPmFkZHJlc3NfbGVu Z3RoOworCQlhZGRyLT5tYXhpbXVtID0gYWRkci0+bWluaW11bSArIGFkZHItPmFkZHJlc3NfbGVu Z3RoIC0gMTsKKwkJcmV0dXJuIEFFX09LOworCWNhc2UgQUNQSV9SRVNPVVJDRV9UWVBFX0FERFJF U1MxNjoKKwljYXNlIEFDUElfUkVTT1VSQ0VfVFlQRV9BRERSRVNTMzI6CisJY2FzZSBBQ1BJX1JF U09VUkNFX1RZUEVfQUREUkVTUzY0OgorCQlzdGF0dXMgPSBhY3BpX3Jlc291cmNlX3RvX2FkZHJl c3M2NChyZXNvdXJjZSwgYWRkcik7CisJCWlmIChBQ1BJX1NVQ0NFU1Moc3RhdHVzKSAmJgorCQkg ICAgKGFkZHItPnJlc291cmNlX3R5cGUgPT0gQUNQSV9NRU1PUllfUkFOR0UgfHwKKwkJICAgIGFk ZHItPnJlc291cmNlX3R5cGUgPT0gQUNQSV9JT19SQU5HRSkgJiYKKwkJICAgIGFkZHItPmFkZHJl c3NfbGVuZ3RoID4gMCkgeworCQkJcmV0dXJuIEFFX09LOworCQl9CisJCWJyZWFrOworCX0KKwly ZXR1cm4gQUVfRVJST1I7Cit9CisKIHN0cnVjdCByZXNfcHJvY19jb250ZXh0IHsKIAlzdHJ1Y3Qg bGlzdF9oZWFkICpsaXN0OwogCWludCAoKnByZXByb2MpKHN0cnVjdCBhY3BpX3Jlc291cmNlICos IHZvaWQgKik7CkluZGV4OiBsaW51eC0yLjYvaW5jbHVkZS9saW51eC9hY3BpLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gbGludXgtMi42Lm9yaWcvaW5jbHVkZS9saW51eC9hY3BpLmgKKysrIGxpbnV4LTIuNi9p bmNsdWRlL2xpbnV4L2FjcGkuaApAQCAtMjU5LDYgKzI1OSw5IEBAIHVuc2lnbmVkIGxvbmcgYWNw aV9kZXZfaXJxX2ZsYWdzKHU4IHRyaWcKIGJvb2wgYWNwaV9kZXZfcmVzb3VyY2VfaW50ZXJydXB0 KHN0cnVjdCBhY3BpX3Jlc291cmNlICphcmVzLCBpbnQgaW5kZXgsCiAJCQkJIHN0cnVjdCByZXNv dXJjZSAqcmVzKTsKIAorYWNwaV9zdGF0dXMgYWNwaV9tZW1fYWRkcl9yZXNvdXJjZV90b19hZGRy ZXNzNjQoc3RydWN0IGFjcGlfcmVzb3VyY2UgKnJlc291cmNlLAorCQkJc3RydWN0IGFjcGlfcmVz b3VyY2VfYWRkcmVzczY0ICphZGRyKTsKKwogc3RydWN0IHJlc291cmNlX2xpc3RfZW50cnkgewog CXN0cnVjdCBsaXN0X2hlYWQgbm9kZTsKIAlzdHJ1Y3QgcmVzb3VyY2UgcmVzOwo= --e89a8ff2528a3944e504e4a28e09-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/