Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600Ab3HXAv5 (ORCPT ); Fri, 23 Aug 2013 20:51:57 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:46121 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990Ab3HXAv4 (ORCPT ); Fri, 23 Aug 2013 20:51:56 -0400 MIME-Version: 1.0 In-Reply-To: <1376189294-32022-27-git-send-email-yinghai@kernel.org> References: <1376189294-32022-1-git-send-email-yinghai@kernel.org> <1376189294-32022-27-git-send-email-yinghai@kernel.org> Date: Sat, 24 Aug 2013 08:51:54 +0800 Message-ID: Subject: Re: [PATCH v4 26/28] PCI, x86, ACPI: Link acpi ioapic register to ioapic From: rui wang To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Bjorn Helgaas , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 58 On 8/11/13, Yinghai Lu wrote: > During ioapic hotplug, acpi_register_ioapic will be called. > Now for x86, that function is blank. > Fill that will update __mp_register_ioapic to use those ioapic. > > Signed-off-by: Yinghai Lu > --- > arch/x86/kernel/acpi/boot.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > index 5be15d1..4a5336d 100644 > --- a/arch/x86/kernel/acpi/boot.c > +++ b/arch/x86/kernel/acpi/boot.c > @@ -707,16 +707,18 @@ EXPORT_SYMBOL(acpi_unmap_lsapic); > > int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base) > { > - /* TBD */ > - return -EINVAL; > + unsigned long long id = 0; > + > + acpi_evaluate_integer(handle, "_UID", NULL, &id); We cannot assume that "_UID" is an integer. "_UID" can be either an integer or a string. Need to consider the case when it is a string. Thanks Rui > + > + return __mp_register_ioapic(id, phys_addr, gsi_base, true); > } > > EXPORT_SYMBOL(acpi_register_ioapic); > > int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base) > { > - /* TBD */ > - return -EINVAL; > + return mp_unregister_ioapic(gsi_base); > } > > EXPORT_SYMBOL(acpi_unregister_ioapic); > -- > 1.8.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/