Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756089Ab3HYFaT (ORCPT ); Sun, 25 Aug 2013 01:30:19 -0400 Received: from mail.active-venture.com ([67.228.131.205]:59667 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755853Ab3HYFaQ (ORCPT ); Sun, 25 Aug 2013 01:30:16 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <52199663.8070201@roeck-us.net> Date: Sat, 24 Aug 2013 22:30:11 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Stephen Warren CC: George Cherian , balbi@ti.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, grant.likely@linaro.org, rob@landley.net, ian.campbell@citrix.com, mark.rutland@arm.com, pawel.moll@arm.co Subject: Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection References: <1376648029-30659-1-git-send-email-george.cherian@ti.com> <1376648029-30659-2-git-send-email-george.cherian@ti.com> <52127284.6030506@wwwdotorg.org> <521312CC.8060003@ti.com> <52139F0F.6090507@wwwdotorg.org> In-Reply-To: <52139F0F.6090507@wwwdotorg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 43 On 08/20/2013 09:53 AM, Stephen Warren wrote: > On 08/20/2013 12:55 AM, George Cherian wrote: >> Hi Stephen, >> >> Thanks for your review. >> >> On 8/20/2013 1:01 AM, Stephen Warren wrote: >> >>> On 08/16/2013 04:13 AM, George Cherian wrote: >>>> Adding extcon driver for USB ID detection to dynamically >>>> configure USB Host/Peripheral mode. >>>> diff --git >>>> a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>>> b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>>> +EXTCON FOR DRA7xx >>>> + >>>> +Required Properties: >>> Please at lest explain what a DRA7xxx is, and the purpose of the HW >>> module this binding describes. >> >> DRA7xx is the SoC name and the USB VID detection is implemented via gpio's >> Basically it does only ID detection via GPIO and there is no VBUS >> detection in h/w. > > If there's no SoC-specific HW, then the binding has nothing to do with > the SoC; it's entirely generic. > I am currently working on adding device tree support to the extcon-gpio driver. Wonder if it would make sense to just use that driver. As far as I can see the only missing part is support for multiple cables and cable naming through device tree properties. Any thoughts ? The patches are not yet clean enough to submit upstream, but I could send them as RFC if there is interest. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/