Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756576Ab3HZIuo (ORCPT ); Mon, 26 Aug 2013 04:50:44 -0400 Received: from goliath.siemens.de ([192.35.17.28]:16632 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945Ab3HZIun (ORCPT ); Mon, 26 Aug 2013 04:50:43 -0400 Message-ID: <521B16B9.4000203@siemens.com> Date: Mon, 26 Aug 2013 10:50:01 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Borislav Petkov CC: Fenghua Yu , Steven Rostedt , H Peter Anvin , Linux Kernel Mailing List , x86 , Ingo Molnar , Thomas Gleixner Subject: Re: x86-32: Early microcode loading stumbles over disabled DYNAMIC_FTRACE References: <5217908E.2040702@siemens.com> <20130823201751.GA16046@pd.tnic> In-Reply-To: <20130823201751.GA16046@pd.tnic> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 26 On 2013-08-23 22:17, Borislav Petkov wrote: > On Fri, Aug 23, 2013 at 06:40:46PM +0200, Jan Kiszka wrote: >> Below some hunks to get it working again - at least in the absence of >> any microcode in the initrd. Marking all involved functions as __init >> is another option (as __init implies notrace). But I bet there is more >> hidden. I see e.g. a pr_warn() in find_cpio_init that should trigger >> the issue as well if we hit the error it reports (btw. printing at >> this point of the boot should not work anyway, should it?). > > I guess we can do early_printk there instead as x86_64_start_kernel() > does it but I'm not sure for the 32-bit case where we call > load_ucode_bsp/ap before we've even enabled paging. early_printk doesn't seem to work as well on 32-bit until paging was enabled. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/