Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 16 Oct 2002 12:13:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 16 Oct 2002 12:13:55 -0400 Received: from packet.digeo.com ([12.110.80.53]:11392 "EHLO packet.digeo.com") by vger.kernel.org with ESMTP id ; Wed, 16 Oct 2002 12:13:55 -0400 Message-ID: <3DAD917E.B62ABDDA@digeo.com> Date: Wed, 16 Oct 2002 09:19:10 -0700 From: Andrew Morton X-Mailer: Mozilla 4.79 [en] (X11; U; Linux 2.5.42 i686) X-Accept-Language: en MIME-Version: 1.0 To: David Howells CC: riel@surriel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] do_generic_file_read / readahead adjustments References: <30738.1034782153@warthog.cambridge.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Oct 2002 16:19:10.0589 (UTC) FILETIME=[C270F2D0:01C2752F] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 23 David Howells wrote: > > The attached patch does the following three things: > > (1) Makes the functions in mm/readahead.c only use struct file* to pass to > readpage(). address_mapping* and file_ra_state* are used instead to keep > track of readahead stuff. > > (2) Adds a new function do_generic_mapping_read() that is similar to > do_generic_file_read(), except that it uses a mapping pointer and a > readahead state pointer to access a file. The file* is only used to pass > to readpage(). > > (3) Turns do_generic_file_read() into an inline function in linux/fs.h that > simply wraps do_generic_mapping_read(). > Seems sensible. Is there something out there which actually uses this? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/