Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757206Ab3HZQpB (ORCPT ); Mon, 26 Aug 2013 12:45:01 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:59208 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757164Ab3HZQo7 (ORCPT ); Mon, 26 Aug 2013 12:44:59 -0400 Date: Mon, 26 Aug 2013 12:44:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Shawn Bohrer cc: linux-usb@vger.kernel.org, , Subject: Re: [PATCH] USB: Fix compilation error when CONFIG_PM disabled In-Reply-To: <1377534914-7145-1-git-send-email-sbohrer@rgmadvisors.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 25 On Mon, 26 Aug 2013, Shawn Bohrer wrote: > Commit 9a11899c5e699a8d "USB: OHCI: add missing PCI PM callbacks to > ohci-pci.c" Introduced the following compilation errors when power > management is disabled: > > drivers/usb/host/ohci-pci.c: In function 'ohci_pci_init': > drivers/usb/host/ohci-pci.c:309:35: error: 'ohci_suspend' undeclared (first use in this function) > drivers/usb/host/ohci-pci.c:309:35: note: each undeclared identifier is reported only once for each function it appears in > drivers/usb/host/ohci-pci.c:310:34: error: 'ohci_resume' undeclared (first use in this function) > > ohci_suspend and ohci_resume are only defined when CONFIG_PM is defined > so only use them under CONFIG_PM. Heh -- beat you to it. http://marc.info/?l=linux-usb&m=137752885015904&w=2 Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/