Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423Ab3HZXPD (ORCPT ); Mon, 26 Aug 2013 19:15:03 -0400 Received: from mail-ve0-f170.google.com ([209.85.128.170]:48548 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575Ab3HZXPB (ORCPT ); Mon, 26 Aug 2013 19:15:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130807153030.GA25515@redhat.com> <20130819231836.GD14369@redhat.com> <20130821204901.GA19802@redhat.com> <20130823032127.GA5098@redhat.com> <20130823035344.GB5098@redhat.com> <20130826190757.GB27768@redhat.com> Date: Mon, 26 Aug 2013 16:15:00 -0700 X-Google-Sender-Auth: PjfnzRurmrLBngt_XP8K12oBb98 Message-ID: Subject: Re: unused swap offset / bad page map. From: Linus Torvalds To: Hugh Dickins Cc: Dave Jones , Cyrill Gorcunov , Hillf Danton , Linux-MM , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 30 On Mon, Aug 26, 2013 at 3:08 PM, Hugh Dickins wrote: > > I just did a quick diff of 3.11-rc7/mm against 3.10, and here's > a line in mremap which worries me. That set_pte_at() is operating > on anything that isn't pte_none(), so the pte_mksoft_dirty() looks > prone to corrupt a swap entry. Uhhuh. I think you hit the nail on the head here. I checked all the pte_swp_*soft_dirty() users (they should be used on swp entries), because that came up in another thread. But you're right, the non-swp ones only work on present pte entries (or on file-offset entries, I guess), and at least that mremap() case seems bogus. I'm not seeing the point of marking the thing soft-dirty at all, although I guess it's "dirty" in the sense that it changed the contents at that virtual address. But for that code to work, it would have to have the same bit for swap entries as for present pages (and for file mapping entries), and that's not true. They are two different bits (_PAGE_SOFT_DIRTY is bit #11 vs _PAGE_SWP_SOFT_DIRTY is bit #7). Ugh. Cyrill, this is a mess. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/