Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156Ab3H0DyV (ORCPT ); Mon, 26 Aug 2013 23:54:21 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:37746 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373Ab3H0DyU (ORCPT ); Mon, 26 Aug 2013 23:54:20 -0400 Message-ID: <521C22EA.1050908@wwwdotorg.org> Date: Mon, 26 Aug 2013 21:54:18 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: boris brezillon CC: Jean-Christophe PLAGNIOL-VILLARD , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Rob Landley , Russell King , Linus Walleij , Jiri Kosina , Masanari Iida , Nicolas Ferre , Richard Genoud , Heiko Stuebner , James Hogan , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf References: <1377379926-11163-1-git-send-email-b.brezillon@overkiz.com> <1377380259-11290-1-git-send-email-b.brezillon@overkiz.com> <20130826175333.GF18627@ns203013.ovh.net> <521BA235.1090104@overkiz.com> In-Reply-To: <521BA235.1090104@overkiz.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 40 On 08/26/2013 12:45 PM, boris brezillon wrote: > Hello Jean-Christophe, > > Le 26/08/2013 19:53, Jean-Christophe PLAGNIOL-VILLARD a ?crit : >> On 23:37 Sat 24 Aug , Boris BREZILLON wrote: >>> Add support for generic pin configuration to pinctrl-at91 driver. ... >>> a/Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt ... >>> configures various pad settings >>> such as pull-up, multi drive, etc. >>> Required properties for iomux controller: >>> -- compatible: "atmel,at91rm9200-pinctrl" >>> +- compatible: "atmel,at91rm9200-pinctrl" or "atmel,at91sam9x5-pinctrl". >>> + Add "generic-pinconf" to the compatible string list to use the >>> generic pin ... >>> +pinctrl@fffff400 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + compatible = "atmel,at91rm9200-pinctrl", "generic-pinconf", >>> "simple-bus"; >> nack your break the backword compatibility >> >> if we use a old kernel with this new dt nothing will work >> as the old kernel will never known the the "generic-pinconf" means >> anything > > Your're right, I didn't think of this case (old kernel with new dt). Well, just to be clear: If a new DT uses a new compatible value of any kind, be it adding "generic-pinconf" or switching to "foo-yyy" rather than "foo-yyy", it won't be compatible... That somewhat implies that you can't ever replace an old binding with something new. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/