Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235Ab3H0IcJ (ORCPT ); Tue, 27 Aug 2013 04:32:09 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39024 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936Ab3H0IcE (ORCPT ); Tue, 27 Aug 2013 04:32:04 -0400 Message-ID: <521C63A0.10902@ti.com> Date: Tue, 27 Aug 2013 14:00:24 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Tomasz Figa CC: Laurent Pinchart , , , , , , Linus Walleij , Sylwester Nawrocki Subject: Re: [PATCH v5] gpio: pcf857x: Add OF support References: <1377590559-14279-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <2063335.Uqxok8bYMn@flatron> In-Reply-To: <2063335.Uqxok8bYMn@flatron> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.24.145.166] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 43 Hi, On Tuesday 27 August 2013 01:44 PM, Tomasz Figa wrote: > Hi Laurent, > > On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote: >> Add DT bindings for the pcf857x-compatible chips and parse the device >> tree node in the driver. >> >> Signed-off-by: Laurent Pinchart >> --- >> .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71 >> ++++++++++++++++++++++ drivers/gpio/gpio-pcf857x.c >> | 44 +++++++++++--- 2 files changed, 107 insertions(+), 8 >> deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt >> >> Changes since v4: >> >> - Don't try to get ngpio from of_device_id data, we already get it from >> i2c_device_id > > Hmm, I'm not sure how this is supposed to work. > > How does the I2C core resolve OF compatible name to particular entry in > id_table? I believe it simply passes NULL as the second argument of > .probe() if the device is instantiated based on OF compatible string and > not one in the legacy ID table. It doesn't pass the second argument as NULL. If you look at i2c_device_probe() in drivers/i2c/i2c-core.c, the second argument to probe is passed as: i2c_match_id(driver->id_table, client) This will extract the i2c_device_id pointer from the id_table. Archit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/