Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853Ab3H0Im3 (ORCPT ); Tue, 27 Aug 2013 04:42:29 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:52491 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305Ab3H0Im0 (ORCPT ); Tue, 27 Aug 2013 04:42:26 -0400 Message-ID: <521C666A.3020508@ozlabs.ru> Date: Tue, 27 Aug 2013 18:42:18 +1000 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Gleb Natapov CC: linuxppc-dev@lists.ozlabs.org, David Gibson , Benjamin Herrenschmidt , Paul Mackerras , kvm@vger.kernel.org, Alexander Graf , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO References: <1376552966-8529-1-git-send-email-aik@ozlabs.ru> <20130827075600.GE22899@redhat.com> In-Reply-To: <20130827075600.GE22899@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2503 Lines: 74 On 08/27/2013 05:56 PM, Gleb Natapov wrote: > On Thu, Aug 15, 2013 at 05:49:26PM +1000, Alexey Kardashevskiy wrote: >> This is to reserve a capablity number for upcoming support >> of VFIO-IOMMU DMA operations in real mode. >> >> The last ioctl in the group which KVM_CREATE_SPAPR_TCE_IOMMU is added to >> is 0xac, the next two numbers are taken - 0xad for KVM_KVMCLOCK_CTRL and > 0xac was also taken by KVM_SET_ONE_REG :( > >> 0xae for KVM_ARM_VCPU_INIT. So the KVM_CREATE_SPAPR_TCE_IOMMU ioclt gets >> 0xaf. >> >> Signed-off-by: Alexey Kardashevskiy >> >> --- >> Changes: >> 2013/08/15 v8: >> * fixed comment again >> >> 2013/08/15: >> * fixed mistype in comments >> * fixed commit message which says what uses ioctls 0xad and 0xae >> >> 2013/07/16: >> * changed the number >> >> 2013/07/11: >> * changed order in a file, added comment about a gap in ioctl number >> --- >> include/uapi/linux/kvm.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 99c2533..bd94127 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -668,6 +668,7 @@ struct kvm_ppc_smmu_info { >> #define KVM_CAP_IRQ_XICS 92 >> #define KVM_CAP_ARM_EL1_32BIT 93 >> #define KVM_CAP_SPAPR_MULTITCE 94 >> +#define KVM_CAP_SPAPR_TCE_IOMMU 95 >> >> #ifdef KVM_CAP_IRQ_ROUTING >> >> @@ -933,6 +934,11 @@ struct kvm_s390_ucas_mapping { >> #define KVM_ARM_SET_DEVICE_ADDR _IOW(KVMIO, 0xab, struct kvm_arm_device_addr) >> /* Available with KVM_CAP_PPC_RTAS */ >> #define KVM_PPC_RTAS_DEFINE_TOKEN _IOW(KVMIO, 0xac, struct kvm_rtas_token_args) >> +/* 0xad is taken by KVM_KVMCLOCK_CTRL */ >> +/* 0xae is taken by KVM_ARM_VCPU_INIT */ >> +/* Available with KVM_CAP_SPAPR_TCE_IOMMU */ >> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xaf, \ >> + struct kvm_create_spapr_tce_iommu) >> > Why not use KVM_CREATE_DEVICE API for that? Because when I came up with my ioctl first time, it was not in upstream and since then nobody pointed me to this new ioctl :) So my stuff is not going to upstream again. Heh. Ok. I'll implement it. > >> /* ioctl for vm fd */ >> #define KVM_CREATE_DEVICE _IOWR(KVMIO, 0xe0, struct kvm_create_device) -- Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/