Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909Ab3H0KIc (ORCPT ); Tue, 27 Aug 2013 06:08:32 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:58405 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961Ab3H0KI3 (ORCPT ); Tue, 27 Aug 2013 06:08:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376189294-32022-1-git-send-email-yinghai@kernel.org> <1376189294-32022-27-git-send-email-yinghai@kernel.org> Date: Tue, 27 Aug 2013 18:08:27 +0800 Message-ID: Subject: Re: [PATCH v4 26/28] PCI, x86, ACPI: Link acpi ioapic register to ioapic From: rui wang To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Bjorn Helgaas , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , ACPI Devel Maling List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2243 Lines: 66 On 8/27/13, Yinghai Lu wrote: > On Mon, Aug 26, 2013 at 11:44 PM, rui wang wrote: >> On 8/27/13, Yinghai Lu wrote: >>> On Fri, Aug 23, 2013 at 5:51 PM, rui wang wrote: >>>> On 8/11/13, Yinghai Lu wrote: >>>>> During ioapic hotplug, acpi_register_ioapic will be called. >>>>> Now for x86, that function is blank. >>>>> Fill that will update __mp_register_ioapic to use those ioapic. >>>>> >>>>> Signed-off-by: Yinghai Lu >>>>> --- >>>>> arch/x86/kernel/acpi/boot.c | 10 ++++++---- >>>>> 1 file changed, 6 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c >>>>> index 5be15d1..4a5336d 100644 >>>>> --- a/arch/x86/kernel/acpi/boot.c >>>>> +++ b/arch/x86/kernel/acpi/boot.c >>>>> @@ -707,16 +707,18 @@ EXPORT_SYMBOL(acpi_unmap_lsapic); >>>>> >>>>> int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 >>>>> gsi_base) >>>>> { >>>>> - /* TBD */ >>>>> - return -EINVAL; >>>>> + unsigned long long id = 0; >>>>> + >>>>> + acpi_evaluate_integer(handle, "_UID", NULL, &id); >>>> >>>> We cannot assume that "_UID" is an integer. "_UID" can be either an >>>> integer or a string. Need to consider the case when it is a string. >>> >>> Yes. >>> >>> But do you have test case for ioapic that _UID is not integer? >>> >> >> Yes I have an IOAPIC with an _UID of: >> >> Name (_UID, "IOAPIC01") // _UID: Unique ID >> >> It's a bit challenge how you'll conjure unique identifiers from both >> integers and strings. If you have a new patch I can help try it out. > > Then do you have _MAT with that ioapic device or else? > > need to find the _MAT entry with GSM matching to find out ioapic id. > There's no _MAT for the IOAPICs. I only find _MAT for the LAPICs. But there's a static MADT in APIC.dsl which contains IOAPIC entries with ioapic ids. Thanks Rui > > Thanks > > Yinghai > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/