Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S261329AbSJPTYZ>; Wed, 16 Oct 2002 15:24:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S261340AbSJPTYZ>; Wed, 16 Oct 2002 15:24:25 -0400
Received: from thunk.org ([140.239.227.29]:61648 "EHLO thunker.thunk.org")
	by vger.kernel.org with ESMTP id <S261329AbSJPTYH>;
	Wed, 16 Oct 2002 15:24:07 -0400
Date: Wed, 16 Oct 2002 15:30:01 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Henning P. Schmiedehausen" <hps@intermeta.de>,
       linux-kernel@vger.kernel.org
Cc: Andreas Dilger <adilger@clusterfs.com>
Subject: Re: [PATCH 2/3] Add extended attributes to ext2/3
Message-ID: <20021016193001.GB1335@think.thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
	"Henning P. Schmiedehausen" <hps@intermeta.de>,
	linux-kernel@vger.kernel.org,
	Andreas Dilger <adilger@clusterfs.com>
References: <E181a3S-0006Nq-00@snap.thunk.org> <aojc1q$l37$1@forge.intermeta.de> <20021016161620.GC8210@think.thunk.org> <20021016170539.GA1201@clusterfs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021016170539.GA1201@clusterfs.com>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1007
Lines: 23

On Wed, Oct 16, 2002 at 11:05:39AM -0600, Andreas Dilger wrote:
> Err, wouldn't that be a 2TB FILE limit, and not a FILESYSTEM limit?

Yes, sorry about that.

I just took a quick look at this, and the limit is unfortunately
fundamental to the VFS; the st_blocks in struct inode and struct kstat
is an unsigned long, which means that we're stuck with the 2TB limit
for *all* filesystems, even using the LFS API.  (Or rather, as you
point out, since no one apparently is doing any overflow checking, so
st_blocks will just be incorrect, even to callers using the stat64
call.)

A quick fix would be to make st_blocks in struct inode and struct
kstat take a __u64 instead of a unsigned long, but it will have a
performance impact.  What do folks think?

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/