Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810Ab3H0QYs (ORCPT ); Tue, 27 Aug 2013 12:24:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020Ab3H0QYr (ORCPT ); Tue, 27 Aug 2013 12:24:47 -0400 Date: Tue, 27 Aug 2013 12:24:27 -0400 From: Dave Jones To: Cyrill Gorcunov Cc: Hugh Dickins , Linus Torvalds , Hillf Danton , Linux-MM , Linux Kernel , Andrew Morton , Pavel Emelyanov Subject: Re: unused swap offset / bad page map. Message-ID: <20130827162427.GA26717@redhat.com> Mail-Followup-To: Dave Jones , Cyrill Gorcunov , Hugh Dickins , Linus Torvalds , Hillf Danton , Linux-MM , Linux Kernel , Andrew Morton , Pavel Emelyanov References: <20130823032127.GA5098@redhat.com> <20130823035344.GB5098@redhat.com> <20130826190757.GB27768@redhat.com> <20130826222833.GA24320@redhat.com> <20130827083718.GC7416@moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130827083718.GC7416@moon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 36 On Tue, Aug 27, 2013 at 12:37:18PM +0400, Cyrill Gorcunov wrote: > On Mon, Aug 26, 2013 at 06:28:33PM -0400, Dave Jones wrote: > > > > > > I've not tried matching up bits with Dave's reports, and just going > > > into a meeting now, but this patch looks worth a try: probably Cyrill > > > can improve it meanwhile to what he actually wants there (I'm > > > surprised anything special is needed for just moving a pte). > > > > > > Hugh > > > > > > --- 3.11-rc7/mm/mremap.c 2013-07-14 17:10:16.640003652 -0700 > > > +++ linux/mm/mremap.c 2013-08-26 14:46:14.460027627 -0700 > > > @@ -126,7 +126,7 @@ static void move_ptes(struct vm_area_str > > > continue; > > > pte = ptep_get_and_clear(mm, old_addr, old_pte); > > > pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr); > > > - set_pte_at(mm, new_addr, new_pte, pte_mksoft_dirty(pte)); > > > + set_pte_at(mm, new_addr, new_pte, pte); > > > } > > > > I'll give this a shot once I'm done with the bisect. > > I managed to trigger the issue as well. The patch below fixes it. > Dave, could you please give it a shot once time permit? Seems to do the trick. Tested-by: Dave Jones Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/