Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523Ab3H0RgF (ORCPT ); Tue, 27 Aug 2013 13:36:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38719 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338Ab3H0RgB (ORCPT ); Tue, 27 Aug 2013 13:36:01 -0400 Date: Tue, 27 Aug 2013 10:38:19 -0700 From: Greg KH To: Kevin Hilman Cc: Alexander Savchenko , jslaby@suse.cz, linux-serial@vger.kernel.org, LKML , balbi@ti.com, linux-omap Subject: Re: [PATCH] serial: omap: Fix IRQ handling return value Message-ID: <20130827173819.GD21564@kroah.com> References: <1374067753-29560-1-git-send-email-oleksandr.savchenko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 40 On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote: > Greg, > > > On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman wrote: > > +Felipe > > > > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko > > wrote: > >> From: Ruchika Kharwar > >> > >> Ensure the Interrupt handling routine return IRQ_HANDLED vs > >> IRQ_NONE. > > > > Why? > > > > By unconditionally returning IRQ_HANDLED, this patch will surely break > > systems where the UART IRQ is shared with other platforms. > > > > I just noticed this patch when bisecting a related problem. Why > > wasn't this Cc'd to linux-omap where OMAP users might have been more > > likely to see it? > > > > Greg, without a better justification in the changelog, I think this > > patch should be dropped from tty-next. > > Can you drop this from tty-next please? > > The authors aren't responding (one of the ti.com addresses bounced) > and this "fix" is most is not correct. Yes, sorry, behind on my pending tty patch queue. I'll try to get to it this week. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/