Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519Ab3H0Rzl (ORCPT ); Tue, 27 Aug 2013 13:55:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:38771 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003Ab3H0Rzk (ORCPT ); Tue, 27 Aug 2013 13:55:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,969,1367996400"; d="scan'208";a="394253019" Date: Tue, 27 Aug 2013 10:55:39 -0700 From: Sarah Sharp To: Dmitry Kasatkin Cc: Dmitry Kasatkin , Greg KH , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled Message-ID: <20130827175539.GB14844@xanatos> References: <7f53397d0aa93e644124037d44188da5067336fc.1377614854.git.d.kasatkin@samsung.com> <7a445b01abe657f0771a9c488e9afcf71d0a5d55.1377614854.git.d.kasatkin@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3770 Lines: 78 Hi Dmitry, This patch looks fine, and applies ok. I'll send it off to Greg with a couple more bug fixes shortly. Sarah Sharp On Tue, Aug 27, 2013 at 05:52:33PM +0300, Dmitry Kasatkin wrote: > Used vim "=" as Sarah suggested. > > - Dmitry > > On Tue, Aug 27, 2013 at 5:47 PM, Dmitry Kasatkin wrote: > > When debug is not enabled and dev_dbg() will expand to nothing, > > log might be flooded with "callbacks suppressed". If it was not > > done on purpose, better to use dev_dbg_ratelimited() instead. > > > > Signed-off-by: Dmitry Kasatkin > > --- > > drivers/usb/host/xhci-ring.c | 24 ++++++++---------------- > > 1 file changed, 8 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > > index 5b08cd8..3cbf1c0 100644 > > --- a/drivers/usb/host/xhci-ring.c > > +++ b/drivers/usb/host/xhci-ring.c > > @@ -3060,14 +3060,10 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags, > > * to set the polling interval (once the API is added). > > */ > > if (xhci_interval != ep_interval) { > > - if (printk_ratelimit()) > > - dev_dbg(&urb->dev->dev, "Driver uses different interval" > > - " (%d microframe%s) than xHCI " > > - "(%d microframe%s)\n", > > - ep_interval, > > - ep_interval == 1 ? "" : "s", > > - xhci_interval, > > - xhci_interval == 1 ? "" : "s"); > > + dev_dbg_ratelimited(&urb->dev->dev, > > + "Driver uses different interval (%d microframe%s) than xHCI (%d microframe%s)\n", > > + ep_interval, ep_interval == 1 ? "" : "s", > > + xhci_interval, xhci_interval == 1 ? "" : "s"); > > urb->interval = xhci_interval; > > /* Convert back to frames for LS/FS devices */ > > if (urb->dev->speed == USB_SPEED_LOW || > > @@ -3849,14 +3845,10 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd *xhci, gfp_t mem_flags, > > * to set the polling interval (once the API is added). > > */ > > if (xhci_interval != ep_interval) { > > - if (printk_ratelimit()) > > - dev_dbg(&urb->dev->dev, "Driver uses different interval" > > - " (%d microframe%s) than xHCI " > > - "(%d microframe%s)\n", > > - ep_interval, > > - ep_interval == 1 ? "" : "s", > > - xhci_interval, > > - xhci_interval == 1 ? "" : "s"); > > + dev_dbg_ratelimited(&urb->dev->dev, > > + "Driver uses different interval (%d microframe%s) than xHCI (%d microframe%s)\n", > > + ep_interval, ep_interval == 1 ? "" : "s", > > + xhci_interval, xhci_interval == 1 ? "" : "s"); > > urb->interval = xhci_interval; > > /* Convert back to frames for LS/FS devices */ > > if (urb->dev->speed == USB_SPEED_LOW || > > -- > > 1.8.1.2 > > > > > > -- > Thanks, > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/